Fixes #1331: Happened on deactivating features for intermediate crafting components

If a feature dependency of ItemMultiMaterial was disabled, the returned value was never assigned with the constructed. Pulling out the construction and setting it before checking it, prevents the NPE and also matches the behaviour in ItemMultiPart, where parts are constructed, but never registered.

src/api/java/appeng/api/definitions/IBlockDefinition.java

@@ -3,6 +3,7 @@ package appeng.api.definitions;
 
 import net.minecraft.block.Block;
 import net.minecraft.item.ItemBlock;
+import net.minecraft.world.IBlockAccess;
 
 import com.google.common.base.Optional;
 
@@ -18,4 +19,16 @@ public interface IBlockDefinition extends IItemDefinition
 	 * @return the {@link ItemBlock} implementation if applicable
 	 */
 	Optional<ItemBlock> maybeItemBlock();
+
+	/**
+	 * Compare Block with world.
+	 *
+	 * @param world world of block
+	 * @param x     x pos of block
+	 * @param y     y pos of block
+	 * @param z     z pos of block
+	 *
+	 * @return if the block is placed in the world at the specific location.
+	 */
+	boolean isSameAs( IBlockAccess world, int x, int y, int z );
 }

src/api/java/appeng/api/definitions/IComparableDefinition.java

@@ -7,6 +7,10 @@ import net.minecraft.world.IBlockAccess;
 
 /**
  * Interface to compare a definition with an itemstack or a block
+ *
+ * @author thatsIch
+ * @version rv2
+ * @since rv2
  */
 public interface IComparableDefinition
 {
@@ -28,6 +32,9 @@ public interface IComparableDefinition
 	 * @param z     z pos of block
 	 *
 	 * @return if the block is placed in the world at the specific location.
+	 *
+	 * @deprecated moved to {@link IBlockDefinition}. Is removed in the next major release rv3
 	 */
+	@Deprecated
 	boolean isSameAs( IBlockAccess world, int x, int y, int z );
 }