Make fields final if possible to ensure immutability
This commit is contained in:
thatsIch
@@ -29,8 +29,8 @@ import appeng.util.iterators.NullIterator;
|
||||
public class ContainerCellWorkbench extends ContainerUpgradeable
|
||||
{
|
||||
|
||||
TileCellWorkbench workBench;
|
||||
AppEngNullInventory ni = new AppEngNullInventory();
|
||||
final TileCellWorkbench workBench;
|
||||
final AppEngNullInventory ni = new AppEngNullInventory();
|
||||
|
||||
public IInventory getCellUpgradeInventory()
|
||||
{
|
||||
|
||||
@@ -8,7 +8,7 @@ import appeng.tile.storage.TileChest;
|
||||
public class ContainerChest extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileChest chest;
|
||||
final TileChest chest;
|
||||
|
||||
public ContainerChest(InventoryPlayer ip, TileChest chest) {
|
||||
super( ip, chest, null );
|
||||
|
||||
@@ -14,7 +14,7 @@ import appeng.util.Platform;
|
||||
public class ContainerCondenser extends AEBaseContainer implements IProgressProvider
|
||||
{
|
||||
|
||||
TileCondenser condenser;
|
||||
final TileCondenser condenser;
|
||||
|
||||
public ContainerCondenser(InventoryPlayer ip, TileCondenser condenser) {
|
||||
super( ip, condenser, null );
|
||||
|
||||
@@ -17,10 +17,10 @@ import appeng.tile.inventory.AppEngInternalInventory;
|
||||
public class ContainerCraftAmount extends AEBaseContainer
|
||||
{
|
||||
|
||||
ITerminalHost priHost;
|
||||
final ITerminalHost priHost;
|
||||
|
||||
public IAEItemStack whatToMake;
|
||||
public Slot craftingItem;
|
||||
public final Slot craftingItem;
|
||||
|
||||
public ContainerCraftAmount(InventoryPlayer ip, ITerminalHost te) {
|
||||
super( ip, te );
|
||||
|
||||
@@ -46,7 +46,7 @@ import com.google.common.collect.ImmutableSet;
|
||||
public class ContainerCraftConfirm extends AEBaseContainer
|
||||
{
|
||||
|
||||
ITerminalHost priHost;
|
||||
final ITerminalHost priHost;
|
||||
public Future<ICraftingJob> job;
|
||||
public ICraftingJob result;
|
||||
|
||||
@@ -76,7 +76,7 @@ public class ContainerCraftConfirm extends AEBaseContainer
|
||||
|
||||
protected long cpuIdx = Long.MIN_VALUE;
|
||||
|
||||
public ArrayList<CraftingCPURecord> cpus = new ArrayList<CraftingCPURecord>();
|
||||
public final ArrayList<CraftingCPURecord> cpus = new ArrayList<CraftingCPURecord>();
|
||||
|
||||
public ContainerCraftConfirm(InventoryPlayer ip, ITerminalHost te) {
|
||||
super( ip, te );
|
||||
|
||||
@@ -35,7 +35,7 @@ public class ContainerCraftingCPU extends AEBaseContainer implements IMEMonitorH
|
||||
String cpuName = null;
|
||||
protected IGrid network;
|
||||
|
||||
IItemList<IAEItemStack> list = AEApi.instance().storage().createItemList();
|
||||
final IItemList<IAEItemStack> list = AEApi.instance().storage().createItemList();
|
||||
|
||||
public ContainerCraftingCPU(InventoryPlayer ip, Object te) {
|
||||
super( ip, te );
|
||||
|
||||
@@ -23,7 +23,7 @@ public class ContainerCraftingStatus extends ContainerCraftingCPU
|
||||
@GuiSync(7)
|
||||
public String myName = "";
|
||||
|
||||
public ArrayList<CraftingCPURecord> cpus = new ArrayList<CraftingCPURecord>();
|
||||
public final ArrayList<CraftingCPURecord> cpus = new ArrayList<CraftingCPURecord>();
|
||||
|
||||
private void sendCPUs()
|
||||
{
|
||||
|
||||
@@ -18,12 +18,12 @@ import appeng.tile.inventory.InvOperation;
|
||||
public class ContainerCraftingTerm extends ContainerMEMonitorable implements IAEAppEngInventory, IContainerCraftingPacket
|
||||
{
|
||||
|
||||
AppEngInternalInventory output = new AppEngInternalInventory( this, 1 );
|
||||
final AppEngInternalInventory output = new AppEngInternalInventory( this, 1 );
|
||||
|
||||
SlotCraftingMatrix craftingSlots[] = new SlotCraftingMatrix[9];
|
||||
SlotCraftingTerm outputSlot;
|
||||
final SlotCraftingMatrix[] craftingSlots = new SlotCraftingMatrix[9];
|
||||
final SlotCraftingTerm outputSlot;
|
||||
|
||||
public PartCraftingTerminal ct;
|
||||
public final PartCraftingTerminal ct;
|
||||
|
||||
/**
|
||||
* Callback for when the crafting matrix is changed.
|
||||
|
||||
@@ -8,7 +8,7 @@ import appeng.tile.storage.TileDrive;
|
||||
public class ContainerDrive extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileDrive drive;
|
||||
final TileDrive drive;
|
||||
|
||||
public ContainerDrive(InventoryPlayer ip, TileDrive drive) {
|
||||
super( ip, drive, null );
|
||||
|
||||
@@ -15,7 +15,7 @@ import appeng.util.Platform;
|
||||
public class ContainerFormationPlane extends ContainerUpgradeable
|
||||
{
|
||||
|
||||
PartFormationPlane storageBus;
|
||||
final PartFormationPlane storageBus;
|
||||
|
||||
public ContainerFormationPlane(InventoryPlayer ip, PartFormationPlane te) {
|
||||
super( ip, te );
|
||||
|
||||
@@ -10,7 +10,7 @@ import appeng.tile.grindstone.TileGrinder;
|
||||
public class ContainerGrinder extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileGrinder grinder;
|
||||
final TileGrinder grinder;
|
||||
|
||||
public ContainerGrinder(InventoryPlayer ip, TileGrinder grinder) {
|
||||
super( ip, grinder, null );
|
||||
|
||||
@@ -16,7 +16,7 @@ import appeng.util.Platform;
|
||||
public class ContainerIOPort extends ContainerUpgradeable
|
||||
{
|
||||
|
||||
TileIOPort ioPort;
|
||||
final TileIOPort ioPort;
|
||||
|
||||
@GuiSync(2)
|
||||
public FullnessMode fMode = FullnessMode.EMPTY;
|
||||
|
||||
@@ -16,11 +16,11 @@ import appeng.util.Platform;
|
||||
public class ContainerInscriber extends ContainerUpgradeable implements IProgressProvider
|
||||
{
|
||||
|
||||
TileInscriber ti;
|
||||
final TileInscriber ti;
|
||||
|
||||
Slot top;
|
||||
Slot middle;
|
||||
Slot bottom;
|
||||
final Slot top;
|
||||
final Slot middle;
|
||||
final Slot bottom;
|
||||
|
||||
@GuiSync(2)
|
||||
public int maxProcessingTime = -1;
|
||||
|
||||
@@ -15,7 +15,7 @@ import appeng.helpers.IInterfaceHost;
|
||||
public class ContainerInterface extends ContainerUpgradeable
|
||||
{
|
||||
|
||||
DualityInterface myDuality;
|
||||
final DualityInterface myDuality;
|
||||
|
||||
@GuiSync(3)
|
||||
public YesNo bMode = YesNo.NO;
|
||||
|
||||
@@ -45,8 +45,8 @@ public class ContainerInterfaceTerminal extends AEBaseContainer
|
||||
class InvTracker
|
||||
{
|
||||
|
||||
long which = autoBase++;
|
||||
String unlocalizedName;
|
||||
final long which = autoBase++;
|
||||
final String unlocalizedName;
|
||||
|
||||
public InvTracker(DualityInterface dual, IInventory patterns, String unlocalizedName) {
|
||||
server = patterns;
|
||||
@@ -55,14 +55,14 @@ public class ContainerInterfaceTerminal extends AEBaseContainer
|
||||
this.sortBy = dual.getSortValue();
|
||||
}
|
||||
|
||||
IInventory client;
|
||||
IInventory server;
|
||||
public long sortBy;
|
||||
final IInventory client;
|
||||
final IInventory server;
|
||||
public final long sortBy;
|
||||
|
||||
}
|
||||
|
||||
Map<IInterfaceHost, InvTracker> diList = new HashMap<IInterfaceHost, InvTracker>();
|
||||
Map<Long, InvTracker> byId = new HashMap<Long, InvTracker>();
|
||||
final Map<IInterfaceHost, InvTracker> diList = new HashMap<IInterfaceHost, InvTracker>();
|
||||
final Map<Long, InvTracker> byId = new HashMap<Long, InvTracker>();
|
||||
IGrid g;
|
||||
|
||||
public ContainerInterfaceTerminal(InventoryPlayer ip, PartMonitor anchor) {
|
||||
|
||||
@@ -21,7 +21,7 @@ import cpw.mods.fml.relauncher.SideOnly;
|
||||
public class ContainerLevelEmitter extends ContainerUpgradeable
|
||||
{
|
||||
|
||||
PartLevelEmitter lvlEmitter;
|
||||
final PartLevelEmitter lvlEmitter;
|
||||
|
||||
@SideOnly(Side.CLIENT)
|
||||
public GuiTextField textField;
|
||||
|
||||
@@ -20,7 +20,7 @@ import appeng.util.Platform;
|
||||
public class ContainerMAC extends ContainerUpgradeable implements IProgressProvider
|
||||
{
|
||||
|
||||
TileMolecularAssembler tma;
|
||||
final TileMolecularAssembler tma;
|
||||
private static final int MAX_CRAFT_PROGRESS = 100;
|
||||
|
||||
public ContainerMAC(InventoryPlayer ip, TileMolecularAssembler te)
|
||||
|
||||
@@ -54,7 +54,7 @@ public class ContainerMEMonitorable extends AEBaseContainer implements IConfigMa
|
||||
final IItemList<IAEItemStack> items = AEApi.instance().storage().createItemList();
|
||||
|
||||
IConfigManager serverCM;
|
||||
IConfigManager clientCM;
|
||||
final IConfigManager clientCM;
|
||||
|
||||
@GuiSync(99)
|
||||
public boolean canAccessViewCells = false;
|
||||
@@ -62,11 +62,11 @@ public class ContainerMEMonitorable extends AEBaseContainer implements IConfigMa
|
||||
@GuiSync(98)
|
||||
public boolean hasPower = false;
|
||||
|
||||
public SlotRestrictedInput cellView[] = new SlotRestrictedInput[5];
|
||||
public final SlotRestrictedInput[] cellView = new SlotRestrictedInput[5];
|
||||
|
||||
public IConfigManagerHost gui;
|
||||
private IGridNode networkNode;
|
||||
private ITerminalHost host;
|
||||
private final ITerminalHost host;
|
||||
|
||||
public IGridNode getNetworkNode()
|
||||
{
|
||||
|
||||
@@ -11,7 +11,7 @@ public class ContainerMEPortableCell extends ContainerMEMonitorable
|
||||
{
|
||||
|
||||
double powerMultiplier = 0.5;
|
||||
IPortableCell civ;
|
||||
final IPortableCell civ;
|
||||
|
||||
public ContainerMEPortableCell(InventoryPlayer ip, IPortableCell monitorable) {
|
||||
super( ip, monitorable, false );
|
||||
|
||||
@@ -12,7 +12,7 @@ import appeng.util.Platform;
|
||||
public class ContainerNetworkTool extends AEBaseContainer
|
||||
{
|
||||
|
||||
INetworkTool toolInv;
|
||||
final INetworkTool toolInv;
|
||||
|
||||
@GuiSync(1)
|
||||
public boolean facadeMode;
|
||||
|
||||
@@ -48,18 +48,18 @@ import appeng.util.item.AEItemStack;
|
||||
public class ContainerPatternTerm extends ContainerMEMonitorable implements IAEAppEngInventory, IOptionalSlotHost, IContainerCraftingPacket
|
||||
{
|
||||
|
||||
AppEngInternalInventory cOut = new AppEngInternalInventory( null, 1 );
|
||||
IInventory crafting;
|
||||
final AppEngInternalInventory cOut = new AppEngInternalInventory( null, 1 );
|
||||
final IInventory crafting;
|
||||
|
||||
SlotFakeCraftingMatrix craftingSlots[] = new SlotFakeCraftingMatrix[9];
|
||||
OptionalSlotFake outputSlots[] = new OptionalSlotFake[3];
|
||||
final SlotFakeCraftingMatrix[] craftingSlots = new SlotFakeCraftingMatrix[9];
|
||||
final OptionalSlotFake[] outputSlots = new OptionalSlotFake[3];
|
||||
|
||||
SlotPatternTerm craftSlot;
|
||||
final SlotPatternTerm craftSlot;
|
||||
|
||||
SlotRestrictedInput patternSlotIN;
|
||||
SlotRestrictedInput patternSlotOUT;
|
||||
final SlotRestrictedInput patternSlotIN;
|
||||
final SlotRestrictedInput patternSlotOUT;
|
||||
|
||||
public PartPatternTerminal ct;
|
||||
public final PartPatternTerminal ct;
|
||||
|
||||
public ContainerPatternTerm(InventoryPlayer ip, ITerminalHost monitorable)
|
||||
{
|
||||
|
||||
@@ -16,7 +16,7 @@ import cpw.mods.fml.relauncher.SideOnly;
|
||||
public class ContainerPriority extends AEBaseContainer
|
||||
{
|
||||
|
||||
IPriorityHost priHost;
|
||||
final IPriorityHost priHost;
|
||||
|
||||
@SideOnly(Side.CLIENT)
|
||||
public GuiTextField textField;
|
||||
|
||||
@@ -8,7 +8,7 @@ import appeng.tile.qnb.TileQuantumBridge;
|
||||
public class ContainerQNB extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileQuantumBridge quantumBridge;
|
||||
final TileQuantumBridge quantumBridge;
|
||||
|
||||
public ContainerQNB(InventoryPlayer ip, TileQuantumBridge quantumBridge) {
|
||||
super( ip, quantumBridge, null );
|
||||
|
||||
@@ -20,11 +20,11 @@ import appeng.util.Platform;
|
||||
public class ContainerQuartzKnife extends AEBaseContainer implements IAEAppEngInventory, IInventory
|
||||
{
|
||||
|
||||
QuartzKnifeObj toolInv;
|
||||
final QuartzKnifeObj toolInv;
|
||||
|
||||
AppEngInternalInventory inSlot = new AppEngInternalInventory( this, 1 );
|
||||
SlotRestrictedInput metals;
|
||||
QuartzKnifeOutput output;
|
||||
final AppEngInternalInventory inSlot = new AppEngInternalInventory( this, 1 );
|
||||
final SlotRestrictedInput metals;
|
||||
final QuartzKnifeOutput output;
|
||||
String myName = "";
|
||||
|
||||
public void setName(String value)
|
||||
|
||||
@@ -23,14 +23,14 @@ import appeng.tile.misc.TileSecurity;
|
||||
public class ContainerSecurity extends ContainerMEMonitorable implements IAEAppEngInventory
|
||||
{
|
||||
|
||||
SlotRestrictedInput configSlot;
|
||||
final SlotRestrictedInput configSlot;
|
||||
|
||||
AppEngInternalInventory wirelessEncoder = new AppEngInternalInventory( this, 2 );
|
||||
final AppEngInternalInventory wirelessEncoder = new AppEngInternalInventory( this, 2 );
|
||||
|
||||
SlotRestrictedInput wirelessIn;
|
||||
SlotOutput wirelessOut;
|
||||
final SlotRestrictedInput wirelessIn;
|
||||
final SlotOutput wirelessOut;
|
||||
|
||||
TileSecurity securityBox;
|
||||
final TileSecurity securityBox;
|
||||
|
||||
public ContainerSecurity(InventoryPlayer ip, ITerminalHost monitorable) {
|
||||
super( ip, monitorable, false );
|
||||
|
||||
@@ -11,7 +11,7 @@ import appeng.tile.storage.TileSkyChest;
|
||||
public class ContainerSkyChest extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileSkyChest chest;
|
||||
final TileSkyChest chest;
|
||||
|
||||
public ContainerSkyChest(InventoryPlayer ip, TileSkyChest chest) {
|
||||
super( ip, chest, null );
|
||||
|
||||
@@ -16,7 +16,7 @@ import appeng.util.Platform;
|
||||
public class ContainerSpatialIOPort extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileSpatialIOPort spatialIOPort;
|
||||
final TileSpatialIOPort spatialIOPort;
|
||||
|
||||
IGrid network;
|
||||
|
||||
|
||||
@@ -26,7 +26,7 @@ import appeng.util.iterators.NullIterator;
|
||||
public class ContainerStorageBus extends ContainerUpgradeable
|
||||
{
|
||||
|
||||
PartStorageBus storageBus;
|
||||
final PartStorageBus storageBus;
|
||||
|
||||
@GuiSync(3)
|
||||
public AccessRestriction rwMode = AccessRestriction.READ_WRITE;
|
||||
|
||||
@@ -29,7 +29,7 @@ import appeng.util.Platform;
|
||||
public class ContainerUpgradeable extends AEBaseContainer implements IOptionalSlotHost
|
||||
{
|
||||
|
||||
IUpgradeableHost upgradeable;
|
||||
final IUpgradeableHost upgradeable;
|
||||
|
||||
int tbSlot;
|
||||
NetworkToolViewer tbInventory;
|
||||
|
||||
@@ -11,7 +11,7 @@ import appeng.util.Platform;
|
||||
public class ContainerVibrationChamber extends AEBaseContainer implements IProgressProvider
|
||||
{
|
||||
|
||||
TileVibrationChamber vibrationChamber;
|
||||
final TileVibrationChamber vibrationChamber;
|
||||
private static final int MAX_BURN_TIME = 200;
|
||||
|
||||
public ContainerVibrationChamber(InventoryPlayer ip, TileVibrationChamber vibrationChamber) {
|
||||
@@ -23,7 +23,7 @@ public class ContainerVibrationChamber extends AEBaseContainer implements IProgr
|
||||
bindPlayerInventory( ip, 0, 166 - /* height of player inventory */82 );
|
||||
}
|
||||
|
||||
public int aePerTick = 5;
|
||||
public final int aePerTick = 5;
|
||||
|
||||
@GuiSync(0)
|
||||
public int burnProgress = 0;
|
||||
|
||||
@@ -10,7 +10,7 @@ import appeng.tile.networking.TileWireless;
|
||||
public class ContainerWireless extends AEBaseContainer
|
||||
{
|
||||
|
||||
TileWireless wirelessTerminal;
|
||||
final TileWireless wirelessTerminal;
|
||||
|
||||
@GuiSync(1)
|
||||
public long range = 0;
|
||||
@@ -18,7 +18,7 @@ public class ContainerWireless extends AEBaseContainer
|
||||
@GuiSync(2)
|
||||
public long drain = 0;
|
||||
|
||||
SlotRestrictedInput boosterSlot;
|
||||
final SlotRestrictedInput boosterSlot;
|
||||
|
||||
public ContainerWireless(InventoryPlayer ip, TileWireless te) {
|
||||
super( ip, te, null );
|
||||
|
||||
@@ -9,7 +9,7 @@ import appeng.util.Platform;
|
||||
public class ContainerWirelessTerm extends ContainerMEPortableCell
|
||||
{
|
||||
|
||||
WirelessTerminalGuiObject wirelessTerminalGUIObject;
|
||||
final WirelessTerminalGuiObject wirelessTerminalGUIObject;
|
||||
|
||||
public ContainerWirelessTerm(InventoryPlayer ip, WirelessTerminalGuiObject wirelessTerminalGUIObject) {
|
||||
super( ip, wirelessTerminalGUIObject );
|
||||
|
||||
@@ -6,12 +6,12 @@ import appeng.util.ItemSorters;
|
||||
public class CraftingCPURecord implements Comparable<CraftingCPURecord>
|
||||
{
|
||||
|
||||
ICraftingCPU cpu;
|
||||
final ICraftingCPU cpu;
|
||||
|
||||
long size;
|
||||
int processors;
|
||||
final long size;
|
||||
final int processors;
|
||||
|
||||
public String myName;
|
||||
public final String myName;
|
||||
|
||||
public CraftingCPURecord(long size, int proc, ICraftingCPU server) {
|
||||
this.size = size;
|
||||
|
||||
Reference in New Issue
Block a user