Make fields final if possible to ensure immutability

This commit is contained in:
thatsIch
2014-09-29 09:54:34 +02:00
parent 35f6c84d9f
commit 474596f095
261 changed files with 607 additions and 597 deletions
+10 -10
View File
@@ -27,9 +27,9 @@ public class CraftingJob implements Runnable, ICraftingJob
IAEItemStack output;
IItemList<IAEItemStack> storage;
final IItemList<IAEItemStack> storage;
HashSet<IAEItemStack> prophecies;
final HashSet<IAEItemStack> prophecies;
boolean simulate = false;
final MECraftingInventory original;
@@ -40,7 +40,7 @@ public class CraftingJob implements Runnable, ICraftingJob
private ICraftingCallback callback;
long bytes = 0;
World world;
final World world;
@Override
public IAEItemStack getOutput()
@@ -105,8 +105,8 @@ public class CraftingJob implements Runnable, ICraftingJob
}
IItemList<IAEItemStack> crafting = AEApi.instance().storage().createItemList();
IItemList<IAEItemStack> missing = AEApi.instance().storage().createItemList();
final IItemList<IAEItemStack> crafting = AEApi.instance().storage().createItemList();
final IItemList<IAEItemStack> missing = AEApi.instance().storage().createItemList();
public void addTask(IAEItemStack what, long crafts, ICraftingPatternDetails details, int depth)
{
@@ -127,11 +127,11 @@ public class CraftingJob implements Runnable, ICraftingJob
class twoIntegers
{
public long perOp = 0;
public long times = 0;
public final long perOp = 0;
public final long times = 0;
}
HashMap<String, twoIntegers> opsAndMultiplier = new HashMap<String, twoIntegers>();
final HashMap<String, twoIntegers> opsAndMultiplier = new HashMap<String, twoIntegers>();
@Override
public void run()
@@ -257,8 +257,8 @@ public class CraftingJob implements Runnable, ICraftingJob
private boolean running = false;
private boolean done = false;
private Object monitor = new Object();
private Stopwatch watch = Stopwatch.createUnstarted();
private final Object monitor = new Object();
private final Stopwatch watch = Stopwatch.createUnstarted();
private int time = 5;
/**