fujin/Applied-Energistics-2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduces visibility of internal fields/methods

Browse Source 
Reduces the visibility of all fields to private and create setters/getters
when necessary. Exceptions are fields with GuiSync as these need to be
public.

Reduces the visibility of internal methods to private/protected/default when possible.
This commit is contained in:
yueh
2015-10-08 15:42:42 +02:00
parent 1ea48fb389
commit 500fc47490
463 changed files with 5670 additions and 3757 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/appeng/helpers/DualityInterface.java
+35 -30
View File
@@ -105,26 +105,26 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
public static final int NUMBER_OF_PATTERN_SLOTS = 9;
private static final Collection<Block> BAD_BLOCKS = new HashSet<Block>( 100 );
final int[] sides = { 0, 1, 2, 3, 4, 5, 6, 7, 8 };
final IAEItemStack[] requireWork = { null, null, null, null, null, null, null, null, null };
final MultiCraftingTracker craftingTracker;
final AENetworkProxy gridProxy;
final IInterfaceHost iHost;
final BaseActionSource mySource;
final BaseActionSource interfaceRequestSource;
final ConfigManager cm = new ConfigManager( this );
final AppEngInternalAEInventory config = new AppEngInternalAEInventory( this, NUMBER_OF_CONFIG_SLOTS );
final AppEngInternalInventory storage = new AppEngInternalInventory( this, NUMBER_OF_STORAGE_SLOTS );
final AppEngInternalInventory patterns = new AppEngInternalInventory( this, NUMBER_OF_PATTERN_SLOTS );
final WrapperInvSlot slotInv = new WrapperInvSlot( this.storage );
final MEMonitorPassThrough<IAEItemStack> items = new MEMonitorPassThrough<IAEItemStack>( new NullInventory<IAEItemStack>(), StorageChannel.ITEMS );
final MEMonitorPassThrough<IAEFluidStack> fluids = new MEMonitorPassThrough<IAEFluidStack>( new NullInventory<IAEFluidStack>(), StorageChannel.FLUIDS );
private final int[] sides = { 0, 1, 2, 3, 4, 5, 6, 7, 8 };
private final IAEItemStack[] requireWork = { null, null, null, null, null, null, null, null, null };
private final MultiCraftingTracker craftingTracker;
private final AENetworkProxy gridProxy;
private final IInterfaceHost iHost;
private final BaseActionSource mySource;
private final BaseActionSource interfaceRequestSource;
private final ConfigManager cm = new ConfigManager( this );
private final AppEngInternalAEInventory config = new AppEngInternalAEInventory( this, NUMBER_OF_CONFIG_SLOTS );
private final AppEngInternalInventory storage = new AppEngInternalInventory( this, NUMBER_OF_STORAGE_SLOTS );
private final AppEngInternalInventory patterns = new AppEngInternalInventory( this, NUMBER_OF_PATTERN_SLOTS );
private final WrapperInvSlot slotInv = new WrapperInvSlot( this.storage );
private final MEMonitorPassThrough<IAEItemStack> items = new MEMonitorPassThrough<IAEItemStack>( new NullInventory<IAEItemStack>(), StorageChannel.ITEMS );
private final MEMonitorPassThrough<IAEFluidStack> fluids = new MEMonitorPassThrough<IAEFluidStack>( new NullInventory<IAEFluidStack>(), StorageChannel.FLUIDS );
private final UpgradeInventory upgrades;
boolean hasConfig = false;
int priority;
List<ICraftingPatternDetails> craftingList = null;
List<ItemStack> waitingToSend = null;
IMEInventory<IAEItemStack> destination;
private boolean hasConfig = false;
private int priority;
private List<ICraftingPatternDetails> craftingList = null;
private List<ItemStack> waitingToSend = null;
private IMEInventory<IAEItemStack> destination;
private boolean isWorking = false;
public DualityInterface( final AENetworkProxy networkProxy, final IInterfaceHost ih )
@@ -138,7 +138,12 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
this.iHost = ih;
this.craftingTracker = new MultiCraftingTracker( this.iHost, 9 );
this.mySource = this.fluids.changeSource = this.items.changeSource = new MachineSource( this.iHost );
final MachineSource actionSource = new MachineSource( this.iHost );
this.mySource = actionSource;
this.fluids.setChangeSource( actionSource );
this.items.setChangeSource( actionSource );
this.interfaceRequestSource = new InterfaceRequestSource( this.iHost );
}
@@ -244,7 +249,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
this.updateCraftingList();
}
public void addToSendList( final ItemStack is )
private void addToSendList( final ItemStack is )
{
if( is == null )
{
@@ -312,7 +317,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
this.notifyNeighbors();
}
public void updateCraftingList()
private void updateCraftingList()
{
final Boolean[] accountedFor = { false, false, false, false, false, false, false, false, false }; // 9...
@@ -365,7 +370,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
}
}
public boolean hasWorkToDo()
private boolean hasWorkToDo()
{
return this.hasItemsToSend() || this.requireWork[0] != null || this.requireWork[1] != null || this.requireWork[2] != null || this.requireWork[3] != null || this.requireWork[4] != null || this.requireWork[5] != null || this.requireWork[6] != null || this.requireWork[7] != null;
}
@@ -439,7 +444,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
}
}
public void addToCraftingList( final ItemStack is )
private void addToCraftingList( final ItemStack is )
{
if( is == null )
{
@@ -463,7 +468,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
}
}
public boolean hasItemsToSend()
private boolean hasItemsToSend()
{
return this.waitingToSend != null && !this.waitingToSend.isEmpty();
}
@@ -540,7 +545,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
@Override
public TickingRequest getTickingRequest( final IGridNode node )
{
return new TickingRequest( TickRates.Interface.min, TickRates.Interface.max, !this.hasWorkToDo(), true );
return new TickingRequest( TickRates.Interface.getMin(), TickRates.Interface.getMax(), !this.hasWorkToDo(), true );
}
@Override
@@ -772,7 +777,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
return this.items;
}
public boolean hasConfig()
private boolean hasConfig()
{
return this.hasConfig;
}
@@ -870,7 +875,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
@Override
public boolean pushPattern( final ICraftingPatternDetails patternDetails, final InventoryCrafting table )
{
if( this.hasItemsToSend() || !this.gridProxy.isActive() )
if( this.hasItemsToSend() || !this.gridProxy.isActive() || !this.craftingList.contains( patternDetails ) )
{
return false;
}
@@ -1073,7 +1078,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
return null;
}
public IPart getPart()
private IPart getPart()
{
return (IPart) ( this.iHost instanceof IPart ? this.iHost : null );
}
@@ -1257,7 +1262,7 @@ public class DualityInterface implements IGridTickable, IStorageMonitorable, IIn
public InterfaceInventory( final DualityInterface tileInterface )
{
super( new AdaptorIInventory( tileInterface.storage ) );
this.mySource = new MachineSource( DualityInterface.this.iHost );
this.setActionSource( new MachineSource( DualityInterface.this.iHost ) );
}
@Override
src/main/java/appeng/helpers/IContainerCraftingPacket.java
+1 -1
View File
@@ -44,7 +44,7 @@ public interface IContainerCraftingPacket
/**
* @return who are we?
*/
BaseActionSource getSource();
BaseActionSource getActionSource();
/**
* @return consume items?
src/main/java/appeng/helpers/LocationRotation.java
+4 -4
View File
@@ -28,10 +28,10 @@ import appeng.api.util.IOrientable;
public class LocationRotation implements IOrientable
{
final IBlockAccess w;
final int x;
final int y;
final int z;
private final IBlockAccess w;
private final int x;
private final int y;
private final int z;
public LocationRotation( final IBlockAccess world, final int x, final int y, final int z )
{
src/main/java/appeng/helpers/MetaRotation.java
+4 -4
View File
@@ -29,10 +29,10 @@ import appeng.api.util.IOrientable;
public class MetaRotation implements IOrientable
{
final IBlockAccess w;
final int x;
final int y;
final int z;
private final IBlockAccess w;
private final int x;
private final int y;
private final int z;
public MetaRotation( final IBlockAccess world, final int x, final int y, final int z )
{
src/main/java/appeng/helpers/MultiCraftingTracker.java
+3 -3
View File
@@ -174,7 +174,7 @@ public class MultiCraftingTracker
}
}
public int getSlot( final ICraftingLink link )
int getSlot( final ICraftingLink link )
{
if( this.links != null )
{
@@ -190,7 +190,7 @@ public class MultiCraftingTracker
return -1;
}
public void cancel()
void cancel()
{
if( this.links != null )
{
@@ -219,7 +219,7 @@ public class MultiCraftingTracker
}
}
public boolean isBusy( final int slot )
boolean isBusy( final int slot )
{
return this.getLink( slot ) != null || this.getJob( slot ) != null;
}
src/main/java/appeng/helpers/PlayerSecurityWrapper.java
+1 -1
View File
@@ -30,7 +30,7 @@ import appeng.api.networking.security.ISecurityRegistry;
public class PlayerSecurityWrapper implements ISecurityRegistry
{
final Map<Integer, EnumSet<SecurityPermissions>> target;
private final Map<Integer, EnumSet<SecurityPermissions>> target;
public PlayerSecurityWrapper( final HashMap<Integer, EnumSet<SecurityPermissions>> playerPerms )
{
src/main/java/appeng/helpers/Splotch.java
+20 -5
View File
@@ -30,9 +30,9 @@ import appeng.api.util.AEColor;
public class Splotch
{
public final ForgeDirection side;
public final boolean lumen;
public final AEColor color;
private final ForgeDirection side;
private final boolean lumen;
private final AEColor color;
private final int pos;
public Splotch( final AEColor col, final boolean lit, final ForgeDirection side, final Vec3 position )
@@ -82,7 +82,7 @@ public class Splotch
public void writeToStream( final ByteBuf stream )
{
stream.writeByte( this.pos );
final int val = this.side.ordinal() | ( this.color.ordinal() << 3 ) | ( this.lumen ? 0x80 : 0x00 );
final int val = this.getSide().ordinal() | ( this.getColor().ordinal() << 3 ) | ( this.isLumen() ? 0x80 : 0x00 );
stream.writeByte( val );
}
@@ -98,7 +98,22 @@ public class Splotch
public int getSeed()
{
final int val = this.side.ordinal() | ( this.color.ordinal() << 3 ) | ( this.lumen ? 0x80 : 0x00 );
final int val = this.getSide().ordinal() | ( this.getColor().ordinal() << 3 ) | ( this.isLumen() ? 0x80 : 0x00 );
return Math.abs( this.pos + val );
}
public ForgeDirection getSide()
{
return this.side;
}
public AEColor getColor()
{
return this.color;
}
public boolean isLumen()
{
return this.lumen;
}
}
src/main/java/appeng/helpers/WirelessTerminalGuiObject.java
+10 -10
View File
@@ -55,16 +55,16 @@ import appeng.tile.networking.TileWireless;
public class WirelessTerminalGuiObject implements IPortableCell, IActionHost, IInventorySlotAware
{
public final ItemStack effectiveItem;
final IWirelessTermHandler wth;
final String encryptionKey;
final EntityPlayer myPlayer;
IGrid targetGrid;
IStorageGrid sg;
IMEMonitor<IAEItemStack> itemStorage;
IWirelessAccessPoint myWap;
double sqRange = Double.MAX_VALUE;
double myRange = Double.MAX_VALUE;
private final ItemStack effectiveItem;
private final IWirelessTermHandler wth;
private final String encryptionKey;
private final EntityPlayer myPlayer;
private IGrid targetGrid;
private IStorageGrid sg;
private IMEMonitor<IAEItemStack> itemStorage;
private IWirelessAccessPoint myWap;
private double sqRange = Double.MAX_VALUE;
private double myRange = Double.MAX_VALUE;
private final int inventorySlot;
public WirelessTerminalGuiObject( final IWirelessTermHandler wh, final ItemStack is, final EntityPlayer ep, final World w, final int x, final int y, final int z )