Closes #1283: Add custom Callable to prevent memory leaks

This commit is contained in:
yueh
2015-08-06 23:30:26 +02:00
committed by thatsIch
parent 20a6e7631f
commit 621952e37d
10 changed files with 163 additions and 77 deletions
+5 -10
View File
@@ -19,30 +19,25 @@
package appeng.util;
import java.util.concurrent.Callable;
import net.minecraft.util.BlockPos;
import net.minecraft.world.World;
public class BlockUpdate implements Callable
public class BlockUpdate implements IWorldCallable<Boolean>
{
final World w;
final BlockPos pos;
public BlockUpdate( World w, BlockPos pos )
public BlockUpdate( BlockPos pos )
{
this.w = w;
this.pos=pos;
}
@Override
public Object call() throws Exception
public Boolean call( World world ) throws Exception
{
if( this.w.isBlockLoaded( this.pos ) )
if ( world.isBlockLoaded( this.pos ) )
{
this.w.notifyNeighborsOfStateChange( this.pos, Platform.AIR_BLOCK );
world.notifyNeighborsOfStateChange( this.pos, Platform.AIR_BLOCK );
}
return true;
@@ -0,0 +1,49 @@
/*
* This file is part of Applied Energistics 2.
* Copyright (c) 2013 - 2015, AlgorithmX2, All rights reserved.
*
* Applied Energistics 2 is free software: you can redistribute it and/or modify
* it under the terms of the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Applied Energistics 2 is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with Applied Energistics 2. If not, see <http://www.gnu.org/licenses/lgpl>.
*/
package appeng.util;
import java.util.concurrent.Callable;
import javax.annotation.Nullable;
import net.minecraft.world.World;
/**
* An interface similar to {@link Callable}, but allowing to pass the {@link World} when calling.
*
* @see Callable
* @author yueh
* @version rv3
* @since rv3
*/
public interface IWorldCallable<T>
{
/**
* Similar to {@link Callable#call()}
*
* @see Callable#call()
* @param world
* @return
* @throws Exception
*/
@Nullable
T call( @Nullable World world ) throws Exception;
}
+1 -1
View File
@@ -2063,7 +2063,7 @@ public class Platform
{
if( !worldObj.isRemote )
{
TickHandler.INSTANCE.addCallable( worldObj, new BlockUpdate( worldObj, pos ) );
TickHandler.INSTANCE.addCallable( worldObj, new BlockUpdate( pos ) );
}
}