Refactored drive state sync

Removed blinking state for now
This commit is contained in:
yueh
2020-06-29 11:45:25 +02:00
parent 400fcdb633
commit 77b544ce4f
8 changed files with 89 additions and 38 deletions
@@ -110,6 +110,13 @@ import appeng.util.item.AEItemStack;
public class ChestTileEntity extends AENetworkPowerTileEntity
implements IMEChest, ITerminalHost, IPriorityHost, IConfigManagerHost, IColorableTile, ITickableTileEntity {
private static final int BIT_POWER_MASK = Byte.MIN_VALUE;
private static final int BIT_STATE_MASK = 0b111;
private static final int BIT_CELL_STATE_MASK = 0b111;
private static final int BIT_CELL_STATE_BITS = 3;
private final AppEngInternalInventory inputInventory = new AppEngInternalInventory(this, 1);
private final AppEngInternalInventory cellInventory = new AppEngInternalInventory(this, 1);
private final IItemHandler internalInventory = new WrapperChainedItemHandler(this.inputInventory,
@@ -163,13 +170,13 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
final int oldState = this.state;
for (int x = 0; x < this.getCellCount(); x++) {
this.state |= (this.getCellStatus(x).ordinal() << (3 * x));
this.state |= (this.getCellStatus(x).ordinal() << (BIT_CELL_STATE_BITS * x));
}
if (this.isPowered()) {
this.state |= 0x40;
this.state |= BIT_POWER_MASK;
} else {
this.state &= ~0x40;
this.state &= ~BIT_POWER_MASK;
}
final boolean currentActive = this.getProxy().isActive();
@@ -245,7 +252,7 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
@Override
public CellState getCellStatus(final int slot) {
if (isRemote()) {
return CellState.values()[(this.state >> (slot * 3)) & 3];
return CellState.values()[(this.state >> (slot * BIT_CELL_STATE_BITS)) & BIT_CELL_STATE_MASK];
}
this.updateHandler();
@@ -273,7 +280,7 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
@Override
public boolean isPowered() {
if (isRemote()) {
return (this.state & 0x40) == 0x40;
return (this.state & BIT_POWER_MASK) == BIT_POWER_MASK;
}
boolean gridPowered = this.getAECurrentPower() > 64;
@@ -290,12 +297,7 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
@Override
public boolean isCellBlinking(final int slot) {
final long now = this.world.getGameTime();
if (now - this.lastStateChange > 8) {
return false;
}
return ((this.state >> (slot * 3 + 2)) & 0x01) == 0x01;
return false;
}
@Override
@@ -327,14 +329,14 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
try {
if (!this.getProxy().getEnergy().isNetworkPowered()) {
final double powerUsed = this.extractAEPower(idleUsage, Actionable.MODULATE, PowerMultiplier.CONFIG); // drain
if (powerUsed + 0.1 >= idleUsage != (this.state & 0x40) > 0) {
if (powerUsed + 0.1 >= idleUsage != (this.state & BIT_POWER_MASK) > 0) {
this.recalculateDisplay();
}
}
} catch (final GridAccessException e) {
final double powerUsed = this.extractAEPower(this.getProxy().getIdlePowerUsage(), Actionable.MODULATE,
PowerMultiplier.CONFIG); // drain
if (powerUsed + 0.1 >= idleUsage != (this.state & 0x40) > 0) {
if (powerUsed + 0.1 >= idleUsage != (this.state & BIT_POWER_MASK) > 0) {
this.recalculateDisplay();
}
}
@@ -348,20 +350,16 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
protected void writeToStream(final PacketBuffer data) throws IOException {
super.writeToStream(data);
if (this.world.getGameTime() - this.lastStateChange > 8) {
this.state = 0;
} else {
this.state &= 0x24924924; // just keep the blinks...
}
this.state = 0;
for (int x = 0; x < this.getCellCount(); x++) {
this.state |= (this.getCellStatus(x).ordinal() << (3 * x));
}
if (this.isPowered()) {
this.state |= 0x40;
this.state |= BIT_POWER_MASK;
} else {
this.state &= ~0x40;
this.state &= ~BIT_POWER_MASK;
}
data.writeByte(this.state);
@@ -519,7 +517,7 @@ public class ChestTileEntity extends AENetworkPowerTileEntity
}
this.lastStateChange = now;
this.state |= 1 << (slot * 3 + 2);
this.state |= 1 << (slot * BIT_CELL_STATE_BITS + 2);
this.recalculateDisplay();
}