fujin/Applied-Energistics-2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some performance or memory optimizations

Browse Source 
Replaced String concat in loops with StringBuilder (performance)
Replaced for with keySet + Map.get() through for with entrySet (perf)
Changed inner classes to static classes, mostly struct like (memory)
This commit is contained in:
yueh
2014-09-30 22:59:49 +02:00
parent d8da97d2af
commit 7fa7e43c29
25 changed files with 86 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/appeng/me/NetworkEventBus.java
+6 -5
View File
@@ -4,6 +4,7 @@ import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.Hashtable;
import java.util.Map.Entry;
import java.util.Set;
import appeng.api.networking.IGridNode;
@@ -14,7 +15,7 @@ import appeng.core.AELog;
public class NetworkEventBus
{
class NetworkEventDone extends Throwable
static class NetworkEventDone extends Throwable
{
private static final long serialVersionUID = -3079021487019171205L;
@@ -129,17 +130,17 @@ public class NetworkEventBus
{
if ( subscribers != null )
{
for (Class o : subscribers.keySet())
for (Entry<Class, MENetworkEventInfo> subscriber : subscribers.entrySet())
{
MENetworkEventInfo target = subscribers.get( o );
GridCacheWrapper cache = g.caches.get( o );
MENetworkEventInfo target = subscriber.getValue();
GridCacheWrapper cache = g.caches.get( subscriber.getKey() );
if ( cache != null )
{
x++;
target.invoke( cache.myCache, e );
}
for (IGridNode obj : g.getMachines( o ))
for (IGridNode obj : g.getMachines( subscriber.getKey() ))
{
x++;
target.invoke( obj.getMachine(), e );