Final fields, params and variables

src/main/java/appeng/client/ClientHelper.java

@@ -104,9 +104,9 @@ public class ClientHelper extends ServerHelper
 	private static final ModelGenerator BLOCK_RENDERER = new ModelGenerator();
 	private final ModelResourceLocation partRenderer = new ModelResourceLocation( new ResourceLocation( AppEng.MOD_ID, "DynamicPartRenderer" ), "inventory" );
 
-	private Map<Object, List<IconReg>> iconRegistrations = new HashMap<>();
-	private List<IconReg> iconTmp = new ArrayList<>();
-	private List<ResourceLocation> extraIcons = new ArrayList<>();
+	private final Map<Object, List<IconReg>> iconRegistrations = new HashMap<>();
+	private final List<IconReg> iconTmp = new ArrayList<>();
+	private final List<ResourceLocation> extraIcons = new ArrayList<>();
 
 	@Override
 	public void configureIcon( final Object item, final String name )

src/main/java/appeng/client/SmartModel.java

@@ -34,7 +34,7 @@ import appeng.client.texture.MissingIcon;
 public class SmartModel implements IBakedModel, ISmartBlockModel, ISmartItemModel
 {
 
-	private BlockRenderInfo aeRenderer;
+	private final BlockRenderInfo aeRenderer;
 
 	private class DefState implements IModelState
 	{

src/main/java/appeng/client/gui/AEBaseGui.java

@@ -93,7 +93,7 @@ public abstract class AEBaseGui extends GuiContainer
 	private Stopwatch dbl_clickTimer = Stopwatch.createStarted();
 	private ItemStack dbl_whichItem;
 	private Slot bl_clicked;
-	private boolean useNEI = false;
+	private final boolean useNEI = false;
 	private boolean subGui;
 
 	public AEBaseGui( final Container container )

src/main/java/appeng/client/render/BusRenderer.java

@@ -187,7 +187,7 @@ public class BusRenderer implements IItemRenderer
 		return this.renderer;
 	}
 
-	public void setRenderer( ModelGenerator renderer )
+	public void setRenderer( final ModelGenerator renderer )
 	{
 		this.renderer = renderer;
 	}

src/main/java/appeng/client/render/IconUnwrapper.java

@@ -10,13 +10,13 @@ import appeng.client.texture.IAESprite;
 public class IconUnwrapper extends TextureAtlasSprite
 {
 
-	private int width;
-	private int height;
+	private final int width;
+	private final int height;
 
-	private float max_u;
-	private float min_u;
-	private float min_v;
-	private float max_v;
+	private final float max_u;
+	private final float min_u;
+	private final float min_v;
+	private final float max_v;
 
 	protected IconUnwrapper(
 			final IAESprite src )

src/main/java/appeng/client/render/ModelGenerator.java

@@ -41,8 +41,8 @@ public class ModelGenerator
 
 	private static final class CachedModel implements IBakedModel
 	{
-		private List<BakedQuad>[] faces = new List[6];
-		private List<BakedQuad> general;
+		private final List<BakedQuad>[] faces = new List[6];
+		private final List<BakedQuad> general;
 
 		public CachedModel()
 		{
@@ -115,7 +115,7 @@ public class ModelGenerator
 
 	private IBlockAccess blockAccess;
 
-	private CachedModel generatedModel = new CachedModel();
+	private final CachedModel generatedModel = new CachedModel();
 
 	// used to create faces...
 	private final FaceBakery faceBakery = new FaceBakery();
@@ -135,11 +135,11 @@ public class ModelGenerator
 	};
 	private EnumSet<EnumFacing> renderFaces = EnumSet.allOf( EnumFacing.class );
 	private boolean flipTexture = false;
-	private List<SMFace> faces = new ArrayList();
+	private final List<SMFace> faces = new ArrayList();
 
 	private int point = 0;
 	private int brightness = -1;
-	private float[][] points = new float[4][];
+	private final float[][] points = new float[4][];
 	private EnumFacing currentFace = EnumFacing.UP;
 	private int color = -1;
 
@@ -636,7 +636,7 @@ public class ModelGenerator
 		return blockAccess;
 	}
 
-	public void setBlockAccess( IBlockAccess blockAccess )
+	public void setBlockAccess( final IBlockAccess blockAccess )
 	{
 		this.blockAccess = blockAccess;
 	}
@@ -646,7 +646,7 @@ public class ModelGenerator
 		return renderAllFaces;
 	}
 
-	public void setRenderAllFaces( boolean renderAllFaces )
+	public void setRenderAllFaces( final boolean renderAllFaces )
 	{
 		this.renderAllFaces = renderAllFaces;
 	}
@@ -656,7 +656,7 @@ public class ModelGenerator
 		return uvRotateBottom;
 	}
 
-	public int setUvRotateBottom( int uvRotateBottom )
+	public int setUvRotateBottom( final int uvRotateBottom )
 	{
 		this.uvRotateBottom = uvRotateBottom;
 		return uvRotateBottom;
@@ -667,7 +667,7 @@ public class ModelGenerator
 		return uvRotateEast;
 	}
 
-	public int setUvRotateEast( int uvRotateEast )
+	public int setUvRotateEast( final int uvRotateEast )
 	{
 		this.uvRotateEast = uvRotateEast;
 		return uvRotateEast;
@@ -678,7 +678,7 @@ public class ModelGenerator
 		return uvRotateNorth;
 	}
 
-	public int setUvRotateNorth( int uvRotateNorth )
+	public int setUvRotateNorth( final int uvRotateNorth )
 	{
 		this.uvRotateNorth = uvRotateNorth;
 		return uvRotateNorth;
@@ -689,7 +689,7 @@ public class ModelGenerator
 		return uvRotateSouth;
 	}
 
-	public int setUvRotateSouth( int uvRotateSouth )
+	public int setUvRotateSouth( final int uvRotateSouth )
 	{
 		this.uvRotateSouth = uvRotateSouth;
 		return uvRotateSouth;
@@ -700,7 +700,7 @@ public class ModelGenerator
 		return uvRotateTop;
 	}
 
-	public int setUvRotateTop( int uvRotateTop )
+	public int setUvRotateTop( final int uvRotateTop )
 	{
 		this.uvRotateTop = uvRotateTop;
 		return uvRotateTop;
@@ -711,7 +711,7 @@ public class ModelGenerator
 		return uvRotateWest;
 	}
 
-	public int setUvRotateWest( int uvRotateWest )
+	public int setUvRotateWest( final int uvRotateWest )
 	{
 		this.uvRotateWest = uvRotateWest;
 		return uvRotateWest;
@@ -722,7 +722,7 @@ public class ModelGenerator
 		return renderMinX;
 	}
 
-	public void setRenderMinX( double renderMinX )
+	public void setRenderMinX( final double renderMinX )
 	{
 		this.renderMinX = renderMinX;
 	}
@@ -732,7 +732,7 @@ public class ModelGenerator
 		return renderMinY;
 	}
 
-	public void setRenderMinY( double renderMinY )
+	public void setRenderMinY( final double renderMinY )
 	{
 		this.renderMinY = renderMinY;
 	}
@@ -742,7 +742,7 @@ public class ModelGenerator
 		return renderMinZ;
 	}
 
-	public void setRenderMinZ( double renderMinZ )
+	public void setRenderMinZ( final double renderMinZ )
 	{
 		this.renderMinZ = renderMinZ;
 	}
@@ -752,7 +752,7 @@ public class ModelGenerator
 		return renderMaxX;
 	}
 
-	public void setRenderMaxX( double renderMaxX )
+	public void setRenderMaxX( final double renderMaxX )
 	{
 		this.renderMaxX = renderMaxX;
 	}
@@ -762,7 +762,7 @@ public class ModelGenerator
 		return renderMaxY;
 	}
 
-	public void setRenderMaxY( double renderMaxY )
+	public void setRenderMaxY( final double renderMaxY )
 	{
 		this.renderMaxY = renderMaxY;
 	}
@@ -772,7 +772,7 @@ public class ModelGenerator
 		return renderMaxZ;
 	}
 
-	public void setRenderMaxZ( double renderMaxZ )
+	public void setRenderMaxZ( final double renderMaxZ )
 	{
 		this.renderMaxZ = renderMaxZ;
 	}
@@ -782,7 +782,7 @@ public class ModelGenerator
 		return flipTexture;
 	}
 
-	public void setFlipTexture( boolean flipTexture )
+	public void setFlipTexture( final boolean flipTexture )
 	{
 		this.flipTexture = flipTexture;
 	}
@@ -792,7 +792,7 @@ public class ModelGenerator
 		return renderFaces;
 	}
 
-	public void setRenderFaces( EnumSet<EnumFacing> renderFaces )
+	public void setRenderFaces( final EnumSet<EnumFacing> renderFaces )
 	{
 		this.renderFaces = renderFaces;
 	}

src/main/java/appeng/client/render/RenderBlocksWorkaround.java

@@ -42,7 +42,7 @@ public class RenderBlocksWorkaround extends ModelGenerator
 		// TODO Auto-generated method stub
 	}
 
-	public void setOpacity( float f )
+	public void setOpacity( final float f )
 	{
 		this.opacity = f;
 	}
@@ -52,7 +52,7 @@ public class RenderBlocksWorkaround extends ModelGenerator
 		return faces;
 	}
 
-	public void setFaces( EnumSet<EnumFacing> faces )
+	public void setFaces( final EnumSet<EnumFacing> faces )
 	{
 		this.faces = faces;
 	}