From b030cb9f00bd2d40989b12b24fd1cf14e1fa367b Mon Sep 17 00:00:00 2001 From: NotMyWing Date: Tue, 18 Mar 2025 18:27:26 +1100 Subject: [PATCH] Fix slot OOB indexing --- src/main/java/appeng/container/AEBaseContainer.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/appeng/container/AEBaseContainer.java b/src/main/java/appeng/container/AEBaseContainer.java index 9d57fa95f..cd5f11693 100644 --- a/src/main/java/appeng/container/AEBaseContainer.java +++ b/src/main/java/appeng/container/AEBaseContainer.java @@ -961,13 +961,13 @@ public abstract class AEBaseContainer extends Container { @Override public ItemStack slotClick(int slotId, int dragType, ClickType clickTypeIn, @NotNull EntityPlayer player) { - final var slot = this.getSlot(slotId); - if (slot instanceof SlotDisabled) { - return ItemStack.EMPTY; - } + if (slotId >= 0) { + final var slot = this.getSlot(slotId); + if (slot instanceof SlotDisabled) { + return ItemStack.EMPTY; + } - if (slotId >= 0 && clickTypeIn == ClickType.PICKUP) { - if (slot instanceof AppEngSlot appEngSlot) { + if (slot instanceof AppEngSlot appEngSlot && clickTypeIn == ClickType.PICKUP) { var slotStack = slot.getStack(); var draggedStack = this.invPlayer.getItemStack();