Add fix for leaking client TEs (#298)

* Add fix for leaking client TEs * Remove client-side markDirty() call
2023-09-27 16:45:55 -07:00
parent 6f822af262
commit bf83de08b2
2 changed files with 24 additions and 6 deletions
@@ -434,12 +434,16 @@ public class AEBaseTile extends TileEntity implements IOrientable, ICommonTile,
    }

    public void saveChanges() {
-        if (this.world != null) {
-            this.world.markChunkDirty(this.pos, this);
-            if (!this.markDirtyQueued) {
-                TickHandler.INSTANCE.addCallable(null, this::markDirtyAtEndOfTick);
-                this.markDirtyQueued = true;
-            }
+        // Clientside should not need to save/markDirty() data
+        if (this.world == null || this.world.isRemote) {
+            return;
+        }
+
+        // Serverside is only queued once per tick to avoid costly operations
+        this.world.markChunkDirty(this.pos, this);
+        if (!this.markDirtyQueued) {
+            TickHandler.INSTANCE.addCallable(null, this::markDirtyAtEndOfTick);
+            this.markDirtyQueued = true;
        }
    }