Reduces visibility of internal fields/methods
Reduces the visibility of all fields to private and create setters/getters when necessary. Exceptions are fields with GuiSync as these need to be public. Reduces the visibility of internal methods to private/protected/default when possible.
This commit is contained in:
@@ -60,8 +60,8 @@ public class AENetworkProxy implements IGridBlock
|
||||
private final IGridProxyable gp;
|
||||
private final boolean worldNode;
|
||||
private final String nbtName; // name
|
||||
public AEColor myColor = AEColor.Transparent;
|
||||
NBTTagCompound data = null; // input
|
||||
private AEColor myColor = AEColor.Transparent;
|
||||
private NBTTagCompound data = null; // input
|
||||
private ItemStack myRepInstance;
|
||||
private boolean isReady = false;
|
||||
private IGridNode node = null;
|
||||
@@ -322,7 +322,7 @@ public class AENetworkProxy implements IGridBlock
|
||||
@Override
|
||||
public AEColor getGridColor()
|
||||
{
|
||||
return this.myColor;
|
||||
return this.getColor();
|
||||
}
|
||||
|
||||
@Override
|
||||
@@ -437,4 +437,14 @@ public class AENetworkProxy implements IGridBlock
|
||||
{
|
||||
this.owner = player;
|
||||
}
|
||||
|
||||
public AEColor getColor()
|
||||
{
|
||||
return this.myColor;
|
||||
}
|
||||
|
||||
public void setColor( final AEColor myColor )
|
||||
{
|
||||
this.myColor = myColor;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -49,7 +49,7 @@ public class AENetworkProxyMultiblock extends AENetworkProxy implements IGridMul
|
||||
return new ProxyNodeIterator( this.getCluster().getTiles() );
|
||||
}
|
||||
|
||||
IAECluster getCluster()
|
||||
private IAECluster getCluster()
|
||||
{
|
||||
return ( (IAEMultiBlock) this.getMachine() ).getCluster();
|
||||
}
|
||||
|
||||
@@ -28,8 +28,8 @@ import appeng.api.networking.energy.IEnergySource;
|
||||
public class ChannelPowerSrc implements IEnergySource
|
||||
{
|
||||
|
||||
final IGridNode node;
|
||||
final IEnergySource realSrc;
|
||||
private final IGridNode node;
|
||||
private final IEnergySource realSrc;
|
||||
|
||||
public ChannelPowerSrc( final IGridNode networkNode, final IEnergySource src )
|
||||
{
|
||||
|
||||
@@ -108,12 +108,12 @@ public class GenericInterestManager<T>
|
||||
return this.container.get( stack );
|
||||
}
|
||||
|
||||
class SavedTransactions
|
||||
private class SavedTransactions
|
||||
{
|
||||
|
||||
public final boolean put;
|
||||
public final IAEStack stack;
|
||||
public final T iw;
|
||||
private final boolean put;
|
||||
private final IAEStack stack;
|
||||
private final T iw;
|
||||
|
||||
public SavedTransactions( final boolean putOperation, final IAEStack myStack, final T watcher )
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user