fujin/Applied-Energistics-2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduces visibility of internal fields/methods

Browse Source 
Reduces the visibility of all fields to private and create setters/getters
when necessary. Exceptions are fields with GuiSync as these need to be
public.

Reduces the visibility of internal methods to private/protected/default when possible.
This commit is contained in:
yueh
2015-10-08 15:42:42 +02:00
parent f054bd699b
commit e94a0cfccf
497 changed files with 7865 additions and 6908 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/appeng/util/Platform.java
+9 -9
View File
@@ -289,7 +289,7 @@ public class Platform
/*
* Simple way to cycle an enum...
*/
public static <T extends Enum> T prevEnum( final T ce )
private static <T extends Enum> T prevEnum( final T ce )
{
final EnumSet valList = EnumSet.allOf( ce.getClass() );
@@ -434,7 +434,7 @@ public class Platform
* Lots of silliness to try and account for weird tag related junk, basically requires that two tags have at least
* something in their tags before it wasts its time comparing them.
*/
public static boolean sameStackStags( final ItemStack a, final ItemStack b )
private static boolean sameStackStags( final ItemStack a, final ItemStack b )
{
if( a == null && b == null )
{
@@ -1809,21 +1809,21 @@ public class Platform
public static boolean securityCheck( final GridNode a, final GridNode b )
{
if( a.lastSecurityKey == -1 && b.lastSecurityKey == -1 )
if( a.getLastSecurityKey() == -1 && b.getLastSecurityKey() == -1 )
{
return false;
}
else if( a.lastSecurityKey == b.lastSecurityKey )
else if( a.getLastSecurityKey() == b.getLastSecurityKey() )
{
return false;
}
final boolean a_isSecure = isPowered( a.getGrid() ) && a.lastSecurityKey != -1;
final boolean b_isSecure = isPowered( b.getGrid() ) && b.lastSecurityKey != -1;
final boolean a_isSecure = isPowered( a.getGrid() ) && a.getLastSecurityKey() != -1;
final boolean b_isSecure = isPowered( b.getGrid() ) && b.getLastSecurityKey() != -1;
if( AEConfig.instance.isFeatureEnabled( AEFeature.LogSecurityAudits ) )
{
AELog.info( "Audit: " + a_isSecure + " : " + b_isSecure + " @ " + a.lastSecurityKey + " vs " + b.lastSecurityKey + " & " + a.playerID + " vs " + b.playerID );
AELog.info( "Audit: " + a_isSecure + " : " + b_isSecure + " @ " + a.getLastSecurityKey() + " vs " + b.getLastSecurityKey() + " & " + a.getPlayerID() + " vs " + b.getPlayerID() );
}
// can't do that son...
@@ -1834,12 +1834,12 @@ public class Platform
if( !a_isSecure && b_isSecure )
{
return checkPlayerPermissions( b.getGrid(), a.playerID );
return checkPlayerPermissions( b.getGrid(), a.getPlayerID() );
}
if( a_isSecure && !b_isSecure )
{
return checkPlayerPermissions( a.getGrid(), b.playerID );
return checkPlayerPermissions( a.getGrid(), b.getPlayerID() );
}
return false;