diff --git a/src/main/java/electroblob/wizardry/Wizardry.java b/src/main/java/electroblob/wizardry/Wizardry.java index 2f6e8e63..2db6f70e 100644 --- a/src/main/java/electroblob/wizardry/Wizardry.java +++ b/src/main/java/electroblob/wizardry/Wizardry.java @@ -143,6 +143,8 @@ public class Wizardry { // Moved to preInit, because apparently it has to be here now. proxy.registerRenderers(); + // It seems this also has to be here + proxy.registerKeyBindings(); } @@ -151,8 +153,6 @@ public class Wizardry { settings.initConfigExtras(); - proxy.registerKeyBindings(); - // Event Handlers GameRegistry.registerWorldGenerator(generator, 0); MinecraftForge.EVENT_BUS.register(new WizardryKeyHandler()); diff --git a/src/main/java/electroblob/wizardry/client/ClientProxy.java b/src/main/java/electroblob/wizardry/client/ClientProxy.java index bca3af8b..2d3b287c 100644 --- a/src/main/java/electroblob/wizardry/client/ClientProxy.java +++ b/src/main/java/electroblob/wizardry/client/ClientProxy.java @@ -155,8 +155,8 @@ public class ClientProxy extends CommonProxy { public static MixedFontRenderer mixedFontRenderer; // Key Bindings - public static final KeyBinding NEXT_SPELL = new KeyBinding("key.wizardry:next_spell", Keyboard.KEY_N, "key.categories.wizardry"); - public static final KeyBinding PREVIOUS_SPELL = new KeyBinding("key.wizardry:previous_spell", Keyboard.KEY_B, "key.categories.wizardry"); + public static final KeyBinding NEXT_SPELL = new KeyBinding("key.wizardry.next_spell", Keyboard.KEY_N, "key.categories.wizardry"); + public static final KeyBinding PREVIOUS_SPELL = new KeyBinding("key.wizardry.previous_spell", Keyboard.KEY_B, "key.categories.wizardry"); // Armour Model public static final ModelBiped WIZARD_ARMOUR_MODEL = new ModelWizardArmour(0.75f); diff --git a/src/main/java/electroblob/wizardry/spell/MindControl.java b/src/main/java/electroblob/wizardry/spell/MindControl.java index 52180686..b3c9c9aa 100644 --- a/src/main/java/electroblob/wizardry/spell/MindControl.java +++ b/src/main/java/electroblob/wizardry/spell/MindControl.java @@ -200,6 +200,8 @@ public class MindControl extends Spell { @SubscribeEvent public static void onLivingSetAttackTargetEvent(LivingSetAttackTargetEvent event){ + + if(event.getTarget() == null) return; // Prevents infinite loops with mind trick if(event.getEntityLiving().isPotionActive(WizardryPotions.mind_control) && MindControl.canControl(event.getEntityLiving())){ @@ -212,7 +214,7 @@ public class MindControl extends Spell { entityNBT.getUniqueId(MindControl.NBT_KEY)); // If the target that the event tried to set is already a valid mind control target, nothing happens. - if(event.getTarget() != null && WizardryUtilities.isValidTarget(caster, event.getTarget())) return; + if(WizardryUtilities.isValidTarget(caster, event.getTarget())) return; if(caster instanceof EntityLivingBase){ @@ -224,8 +226,7 @@ public class MindControl extends Spell { } } // If the caster couldn't be found or no valid target was found, this just acts like mind trick. - // If the target is null already, no need to set it to null, or infinite loops will occur. - if(event.getTarget() != null) ((EntityLiving)event.getEntityLiving()).setAttackTarget(null); + ((EntityLiving)event.getEntityLiving()).setAttackTarget(null); } } diff --git a/src/main/java/electroblob/wizardry/util/WizardryUtilities.java b/src/main/java/electroblob/wizardry/util/WizardryUtilities.java index b2c79d6b..c0526b15 100644 --- a/src/main/java/electroblob/wizardry/util/WizardryUtilities.java +++ b/src/main/java/electroblob/wizardry/util/WizardryUtilities.java @@ -1079,6 +1079,7 @@ public final class WizardryUtilities { */ public static Item getWand(Tier tier, Element element){ if(tier == null) throw new NullPointerException("The given tier cannot be null."); + if(element == null) element = Element.MAGIC; return WizardryItems.WAND_MAP.get(ImmutablePair.of(tier, element)); } } diff --git a/src/main/resources/assets/wizardry/lang/en_gb.lang b/src/main/resources/assets/wizardry/lang/en_gb.lang index ac04233e..61a1d1bb 100644 --- a/src/main/resources/assets/wizardry/lang/en_gb.lang +++ b/src/main/resources/assets/wizardry/lang/en_gb.lang @@ -616,8 +616,8 @@ enchantment.wizardry:freezing_weapon=Frost Imbuement key.categories.wizardry=Wizardry -key.wizardry:next_spell=Next Spell -key.wizardry:previous_spell=Previous Spell +key.wizardry.next_spell=Next Spell +key.wizardry.previous_spell=Previous Spell death.attack.wizardry_magic=%1$s was killed by %2$s using magic death.attack.indirect_wizardry_magic=%1$s was killed by %2$s using magic diff --git a/src/main/resources/assets/wizardry/lang/en_us.lang b/src/main/resources/assets/wizardry/lang/en_us.lang index c522167e..1ada8354 100644 --- a/src/main/resources/assets/wizardry/lang/en_us.lang +++ b/src/main/resources/assets/wizardry/lang/en_us.lang @@ -616,8 +616,8 @@ enchantment.wizardry:freezing_weapon=Frost Imbuement key.categories.wizardry=Wizardry -key.wizardry:next_spell=Next Spell -key.wizardry:previous_spell=Previous Spell +key.wizardry.next_spell=Next Spell +key.wizardry.previous_spell=Previous Spell death.attack.wizardry_magic=%1$s was killed by %2$s using magic death.attack.indirect_wizardry_magic=%1$s was killed by %2$s using magic diff --git a/src/main/resources/assets/wizardry/lang/es_es.lang b/src/main/resources/assets/wizardry/lang/es_es.lang index 4ec7dc08..977d7123 100644 --- a/src/main/resources/assets/wizardry/lang/es_es.lang +++ b/src/main/resources/assets/wizardry/lang/es_es.lang @@ -615,8 +615,8 @@ enchantment.wizardry:freezing_weapon=Impregnacion de Fuego key.categories.wizardry=Wizardry -key.wizardry:next_spell=Hechizo siguiente -key.wizardry:previous_spell=Hechizo anterior +key.wizardry.next_spell=Hechizo siguiente +key.wizardry.previous_spell=Hechizo anterior death.attack.wizardry_magic=%1$s fue matado por %2$s usando magia death.attack.indirect_wizardry_magic=%1$s fue matado por %2$s usando magia diff --git a/src/main/resources/assets/wizardry/lang/es_mx.lang b/src/main/resources/assets/wizardry/lang/es_mx.lang index 4ec7dc08..977d7123 100644 --- a/src/main/resources/assets/wizardry/lang/es_mx.lang +++ b/src/main/resources/assets/wizardry/lang/es_mx.lang @@ -615,8 +615,8 @@ enchantment.wizardry:freezing_weapon=Impregnacion de Fuego key.categories.wizardry=Wizardry -key.wizardry:next_spell=Hechizo siguiente -key.wizardry:previous_spell=Hechizo anterior +key.wizardry.next_spell=Hechizo siguiente +key.wizardry.previous_spell=Hechizo anterior death.attack.wizardry_magic=%1$s fue matado por %2$s usando magia death.attack.indirect_wizardry_magic=%1$s fue matado por %2$s usando magia