From 970894ea215503d3e8d51ba5a330eba26f968c11 Mon Sep 17 00:00:00 2001 From: Electroblob77 <35599699+Electroblob77@users.noreply.github.com> Date: Sat, 3 Oct 2020 00:54:29 +0100 Subject: [PATCH] Comments and TODOs --- .../wizardry/registry/WizardryAdvancementTriggers.java | 1 + .../electroblob/wizardry/tileentity/TileEntityStatue.java | 4 +++- src/main/java/electroblob/wizardry/util/ParticleBuilder.java | 5 +++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/electroblob/wizardry/registry/WizardryAdvancementTriggers.java b/src/main/java/electroblob/wizardry/registry/WizardryAdvancementTriggers.java index 06ac7777..ae6537bd 100644 --- a/src/main/java/electroblob/wizardry/registry/WizardryAdvancementTriggers.java +++ b/src/main/java/electroblob/wizardry/registry/WizardryAdvancementTriggers.java @@ -26,6 +26,7 @@ public final class WizardryAdvancementTriggers { public static final CustomAdvancementTrigger spell_failure = new CustomAdvancementTrigger("trigger_spell_failure"); public static final CustomAdvancementTrigger wand_levelup = new CustomAdvancementTrigger("trigger_wand_levelup"); public static final CustomAdvancementTrigger restore_imbuement_altar = new CustomAdvancementTrigger("restore_imbuement_altar"); + // TODO: Make a proper imbuement altar trigger like the arcane workbench one public static final CustomAdvancementTrigger create_elemental_armour = new CustomAdvancementTrigger("create_elemental_armour"); public static final StructureTrigger visit_structure = new StructureTrigger(new ResourceLocation(Wizardry.MODID, "visit_structure")); diff --git a/src/main/java/electroblob/wizardry/tileentity/TileEntityStatue.java b/src/main/java/electroblob/wizardry/tileentity/TileEntityStatue.java index 33fe6d58..86580482 100644 --- a/src/main/java/electroblob/wizardry/tileentity/TileEntityStatue.java +++ b/src/main/java/electroblob/wizardry/tileentity/TileEntityStatue.java @@ -46,7 +46,9 @@ public class TileEntityStatue extends TileEntity implements ITickable { /** * The position within the petrified creature this particular tileentity holds. 1 is at the bottom. */ - public int position = 1; // TODO: Remove this, there is no need for more than 1 TE per statue + // TODO: Remove this, there is no need for more than 1 TE per statue - actually, there is in the case of petrified + // creatures, which should show the block breaking animation on all parts... except this is also broken! + public int position = 1; public void setCreatureAndPart(EntityLiving entity, int position, int parts){ this.creature = entity; diff --git a/src/main/java/electroblob/wizardry/util/ParticleBuilder.java b/src/main/java/electroblob/wizardry/util/ParticleBuilder.java index be238a8f..7603d8f6 100644 --- a/src/main/java/electroblob/wizardry/util/ParticleBuilder.java +++ b/src/main/java/electroblob/wizardry/util/ParticleBuilder.java @@ -44,8 +44,9 @@ import java.util.Random; // Strictly speaking, this isn't a builder class in the traditional sense, because rather than returning the built // object at the end, it sends it to be processed instead and returns nothing. Additionally, unlike most builders -// it's a singleton, because it's likely to be called very frequently and there's no point making a new instance -// every time and clogging the heap with objects. It's also lazy, see the comment about builder variables below. +// it's a singleton, because it's likely to be called very frequently and since this only happens from a single (client) +// thread, there's no point making a new instance every time and clogging the heap with objects. It's also lazy, see +// the comment about builder variables below. public final class ParticleBuilder { /** The static instance of the particle builder. */