fujin/rtorrent
1
0
Fork 0
mirror of https://github.com/rakshasa/rtorrent.git synced 2026-10-05 05:39:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject division overflow in math.div and math.mod.

Browse Source 
Dividing the smallest integer by -1 traps and takes the process with it.
This commit is contained in:
xirvik
2026-08-17 15:19:31 +00:00
committed by Jari Sundell
parent d73f245692
commit 13e073d9ff
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/command_ui.cc
+8 -2
View File
@@ -3,6 +3,7 @@
#include <sys/types.h> #include <sys/types.h>
#include <ctime> #include <ctime>
#include <limits>
#include <regex> #include <regex>
#include <torrent/utils/log.h> #include <torrent/utils/log.h>
@@ -674,8 +675,13 @@ apply_math_basic(const char* name, Comp op, const torrent::Object::list_type& ar
throw torrent::input_error(std::string(name) + ": Wrong argument type"); throw torrent::input_error(std::string(name) + ": Wrong argument type");
} }
if (divides && !rhs && itr != args.begin()) if (divides && itr != args.begin()) {
throw torrent::input_error(std::string(name) + ": Division by zero!"); if (rhs == 0)
throw torrent::input_error(std::string(name) + ": Division by zero!");
if (val == std::numeric_limits<int64_t>::min() && rhs == -1)
throw torrent::input_error(std::string(name) + ": Division overflow!");
}
val = itr == args.begin() ? rhs : op(val, rhs); val = itr == args.begin() ? rhs : op(val, rhs);