fujin/rtorrent
1
0
Fork 0
mirror of https://github.com/rakshasa/rtorrent.git synced 2026-08-08 03:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use empty() instead of checking size

Browse Source 
Also use a const pointer for a child element
This commit is contained in:
kannibalox
2024-11-03 09:43:11 -05:00
committed by Jari Sundell
parent 730d43b6c7
commit 4b7c3ffafe
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rpc/xmlrpc_tinyxml2.cc
+2 -2
View File
@@ -248,7 +248,7 @@ torrent::Object execute_command(std::string method_name, const tinyxml2::XMLElem
rpc::target_type target = rpc::make_target();
if (params_element != nullptr) {
// Parse out the target if available
auto child = params_element->FirstChildElement("param");
const auto* child = params_element->FirstChildElement("param");
if (child != nullptr) {
XmlRpc::object_to_target(xml_value_to_object(child->FirstChildElement("value")), cmd_itr->second.m_flags, &target);
child = child->NextSiblingElement("param");
@@ -259,7 +259,7 @@ torrent::Object execute_command(std::string method_name, const tinyxml2::XMLElem
}
}
}
if (params.size() == 0 && (cmd_itr->second.m_flags & (CommandMap::flag_file_target | CommandMap::flag_tracker_target))) {
if (params.empty() && (cmd_itr->second.m_flags & (CommandMap::flag_file_target | CommandMap::flag_tracker_target))) {
throw xmlrpc_error(XMLRPC_TYPE_ERROR, "invalid parameters: too few");
}
return rpc::commands.call_command(cmd_itr, params_raw, target);