fujin/rtorrent
1
0
Fork 0
mirror of https://github.com/rakshasa/rtorrent.git synced 2026-10-21 16:46:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix critical memory leak

Browse Source 
This commit fixes a critical memory leak with the inserting RPC commands. We must initialize the cmd_flags with the delete key, otherwise they hang around in memory forever; potentially leaking significant amounts of resources.
This commit is contained in:
stickz
2024-09-06 11:16:47 -04:00
parent 4e246a401f
commit 6e9902c23b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/command_dynamic.cc
+2 -1
View File
@@ -171,7 +171,8 @@ system_method_insert_object(const torrent::Object::list_type& args, int flags) {
throw torrent::input_error("Invalid type."); throw torrent::input_error("Invalid type.");
} }
int cmd_flags = 0; // We must initialize this varriable to prevent a critical memory leak
int cmd_flags = rpc::CommandMap::flag_delete_key;
if (!(flags & rpc::object_storage::flag_static)) if (!(flags & rpc::object_storage::flag_static))
cmd_flags |= rpc::CommandMap::flag_modifiable; cmd_flags |= rpc::CommandMap::flag_modifiable;