From 8dd8d691c53c2010bd83a431e6c1be5433e8fbc6 Mon Sep 17 00:00:00 2001
From: kannibalox <kannibalox@gmail.com>
Date: Sun, 3 Nov 2024 09:29:15 -0500
Subject: [PATCH] Explicitly check result of std::strncmp

---
 src/rpc/xmlrpc_tinyxml2.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc/xmlrpc_tinyxml2.cc b/src/rpc/xmlrpc_tinyxml2.cc
index 462454af..83e49b59 100644
--- a/src/rpc/xmlrpc_tinyxml2.cc
+++ b/src/rpc/xmlrpc_tinyxml2.cc
@@ -115,7 +115,7 @@ xml_value_to_object(const tinyxml2::XMLNode* elem) {
   if (elem == nullptr) {
     throw xmlrpc_error(XMLRPC_INTERNAL_ERROR, "received null element to convert");
   }
-  if (std::strncmp(elem->Value(), "value", sizeof("value"))) {
+  if (std::strncmp(elem->Value(), "value", sizeof("value")) != 0) {
     throw xmlrpc_error(XMLRPC_INTERNAL_ERROR, "received non-value element to convert");
   }
   auto root_element = elem->FirstChild();