fujin/rtorrent
1
0
Fork 0
mirror of https://github.com/rakshasa/rtorrent.git synced 2026-10-17 14:46:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Guard the unit multiplication in value commands against overflow.

Browse Source 
The kb variants multiply the argument by 1024 without checking the range.
This commit is contained in:
xirvik
2026-08-17 15:21:24 +00:00
committed by Jari Sundell
parent a2fabb10de
commit 9066afc063
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rpc/command.cc
+9 -1
View File
@@ -1,5 +1,7 @@
#include "config.h"
#include <limits>
#include "core/download.h"
#include "parse.h"
@@ -41,7 +43,13 @@ command_base_call_value_base(command_base* command_raw, target_type target, cons
return command_base::_call<typename command_value_function<T>::type, T>(command_raw, target, val);
}
return command_base::_call<typename command_value_function<T>::type, T>(command_raw, target, unit * arg.as_value());
auto value = arg.as_value();
if (value > std::numeric_limits<int64_t>::max() / unit ||
value < std::numeric_limits<int64_t>::min() / unit)
throw torrent::input_error("Value out of range.");
return command_base::_call<typename command_value_function<T>::type, T>(command_raw, target, unit * value);
}
template <typename T> const torrent::Object