diff --git a/src/command_network.cc b/src/command_network.cc index b07d9d14..6d19e987 100644 --- a/src/command_network.cc +++ b/src/command_network.cc @@ -248,8 +248,8 @@ initialize_command_network() { CMD2_ANY_U ("network.xmlrpc.size_limit", [](const auto&, const auto&) { return rpc::rpc.size_limit(); }); CMD2_ANY_VALUE_V_U ("network.xmlrpc.size_limit.set", [](const auto&, const auto& arg) { return rpc::rpc.set_size_limit(arg); }); - CMD2_VAR_BOOL_U ("network.rpc.use_xmlrpc", true); - CMD2_VAR_BOOL_U ("network.rpc.use_jsonrpc", true); + CMD2_VAR_BOOL_U_GET("network.rpc.use_xmlrpc", true); + CMD2_VAR_BOOL_U_GET("network.rpc.use_jsonrpc", true); CMD2_ANY ("network.block.ipv4", [nw_config](auto, auto) { return nw_config->is_block_ipv4(); }); CMD2_ANY_VALUE_V ("network.block.ipv4.set", [nw_config](auto, auto& value) { return nw_config->set_block_ipv4(value); }); diff --git a/src/rpc/scgi_task.cc b/src/rpc/scgi_task.cc index 25afa912..3046e9d5 100644 --- a/src/rpc/scgi_task.cc +++ b/src/rpc/scgi_task.cc @@ -3,7 +3,6 @@ #include "rpc/scgi_task.h" #include -#include #include #include #include @@ -316,17 +315,7 @@ SCgiTask::receive_call(const char* buffer, uint32_t length) { }); } catch (...) { rpc::RpcManager::set_trusted(true); - - // Send a generic error response instead of re-throwing, as the - // callback infrastructure may not support exception propagation. - const char* err_xml = "" - "faultCode-500" - "faultStringInternal error" - ""; - const char* err_json = "{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32603,\"message\":\"Internal error\"},\"id\":null}"; - const char* err = (rpc_type == RpcManager::RPCType::JSON) ? err_json : err_xml; - result_callback(err, std::strlen(err)); - return; + throw; } rpc::RpcManager::set_trusted(true); diff --git a/src/rpc/xmlrpc_c.cc b/src/rpc/xmlrpc_c.cc index cf05dde2..cf80b83a 100644 --- a/src/rpc/xmlrpc_c.cc +++ b/src/rpc/xmlrpc_c.cc @@ -396,14 +396,6 @@ xmlrpc_call_command(xmlrpc_env* env, xmlrpc_value* args, void* voidServerInfo) { } catch (torrent::local_error& e) { xmlrpc_env_set_fault(env, XMLRPC_PARSE_ERROR, e.what()); return NULL; - - } catch (std::exception& e) { - xmlrpc_env_set_fault(env, XMLRPC_PARSE_ERROR, e.what()); - return NULL; - - } catch (...) { - xmlrpc_env_set_fault(env, XMLRPC_PARSE_ERROR, "Unknown exception in command execution."); - return NULL; } }