fujin/rtorrent
1
0
Fork 0
mirror of https://github.com/rakshasa/rtorrent.git synced 2026-10-05 13:49:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject out-of-range RPC values instead of narrowing them silently.

Browse Source 
Guards choke group max, set-port and info-hash length; parsing now uses std::from_chars.
This commit is contained in:
xirvik
2026-09-19 01:03:55 +00:00
parent 05cdd03cd2
commit f79cb257d7
15 changed files with 424 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/rpc/test_parse.cc
+85
View File
@@ -0,0 +1,85 @@
#include "config.h"
#include "test/rpc/test_parse.h"
#include <cstdint>
#include <limits>
#include "rpc/parse.h"
CPPUNIT_TEST_SUITE_REGISTRATION(TestParse);
void
TestParse::test_whole_value_in_range() {
int64_t value = 0;
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("9223372036854775807", &value));
CPPUNIT_ASSERT_EQUAL(std::numeric_limits<int64_t>::max(), value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("-9223372036854775808", &value));
CPPUNIT_ASSERT_EQUAL(std::numeric_limits<int64_t>::min(), value);
}
void
TestParse::test_whole_value_out_of_range() {
int64_t value = 0;
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("9223372036854775808", &value));
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("-9223372036854775809", &value));
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("99999999999999999999999999", &value));
}
void
TestParse::test_whole_value_bases() {
int64_t value = 0;
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("0x1f", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{31}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("0X1F", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{31}, value);
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("-0x1f", &value));
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("0022", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{22}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("22", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{22}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("1f", &value, 16));
CPPUNIT_ASSERT_EQUAL(int64_t{31}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("0x1f", &value, 16));
CPPUNIT_ASSERT_EQUAL(int64_t{31}, value);
const char* no_digits = "0x";
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow(no_digits, &value));
CPPUNIT_ASSERT_EQUAL(no_digits, rpc::parse_value_nothrow(no_digits, &value));
const char* bad_digits = "0xzz";
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow(bad_digits, &value));
CPPUNIT_ASSERT_EQUAL(bad_digits, rpc::parse_value_nothrow(bad_digits, &value));
}
void
TestParse::test_whole_value_prefixes() {
int64_t value = 0;
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("+5", &value));
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow(" 5 ", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{5}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("5k", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{5120}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("yes", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{1}, value);
CPPUNIT_ASSERT(rpc::parse_whole_value_nothrow("false", &value));
CPPUNIT_ASSERT_EQUAL(int64_t{0}, value);
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("junk", &value));
CPPUNIT_ASSERT(!rpc::parse_whole_value_nothrow("", &value));
}
test/rpc/test_parse.h
+18
View File
@@ -0,0 +1,18 @@
#include "test/helpers/test_fixture.h"
class TestParse : public test_fixture {
CPPUNIT_TEST_SUITE(TestParse);
CPPUNIT_TEST(test_whole_value_in_range);
CPPUNIT_TEST(test_whole_value_out_of_range);
CPPUNIT_TEST(test_whole_value_bases);
CPPUNIT_TEST(test_whole_value_prefixes);
CPPUNIT_TEST_SUITE_END();
public:
void test_whole_value_in_range();
void test_whole_value_out_of_range();
void test_whole_value_bases();
void test_whole_value_prefixes();
};