fujin/rtorrent
1
0
Fork 0
mirror of https://github.com/rakshasa/rtorrent.git synced 2026-10-10 08:09:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add test case for bad boolean value

Browse Source
This commit is contained in:
kannibalox
2024-10-27 17:15:29 -04:00
committed by Jari Sundell
parent dd0c62c7f7
commit fd1d5dbdb2
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/rpc/xmlrpc_tinyxml2.cc
+1 -1
View File
@@ -130,7 +130,7 @@ xml_value_to_object(const tinyxml2::XMLNode* elem) {
} else if (boolean_text == "0") { } else if (boolean_text == "0") {
return torrent::Object((int64_t)0); return torrent::Object((int64_t)0);
} }
throw xmlrpc_error(XMLRPC_INTERNAL_ERROR, "unknown boolean value: " + boolean_text); throw xmlrpc_error(XMLRPC_TYPE_ERROR, "unknown boolean value: " + boolean_text);
} else if (value_element_type == "array") { } else if (value_element_type == "array") {
auto array = torrent::Object::create_list(); auto array = torrent::Object::create_list();
auto data_element = element_access(value_element->ToElement(), "data"); auto data_element = element_access(value_element->ToElement(), "data");
test/rpc/xmlrpc_test_data.txt
+4
View File
@@ -57,3 +57,7 @@ thodCall><methodName>test_a</methodName><params><param><value><i4>41</i4></value
# Invalid - non-integer i4 # Invalid - non-integer i4
<?xml version="1.0"?><methodCall><methodName>xmlrpc_reflect</methodName><params><param><value><i4>string value</i4></value></param></params></methodCall> <?xml version="1.0"?><methodCall><methodName>xmlrpc_reflect</methodName><params><param><value><i4>string value</i4></value></param></params></methodCall>
<?xml version="1.0"?><methodReponse><fault><struct><member><name>faultCode</name><value><int>-501</int></value></member><member><name>faultString</name><value><string>unable to parse integer value</string></value></member></struct></fault></methodReponse> <?xml version="1.0"?><methodReponse><fault><struct><member><name>faultCode</name><value><int>-501</int></value></member><member><name>faultString</name><value><string>unable to parse integer value</string></value></member></struct></fault></methodReponse>
# Invalid - non-boolean boolean
<?xml version="1.0"?><methodCall><methodName>xmlrpc_reflect</methodName><params><param><value><boolean>string value</boolean></value></param></params></methodCall>
<?xml version="1.0"?><methodReponse><fault><struct><member><name>faultCode</name><value><int>-501</int></value></member><member><name>faultString</name><value><string>unknown boolean value: string value</string></value></member></struct></fault></methodReponse>