Change the message when expecting side effect
The previous behavior is really surprising:
```
some_command* [enter/ctrl+c]
|<~~~~~~~~~~~>|<~~~~~~~~~~~~>|
| bold text | normal weight|
```
as if the '*' is part of the command to be executed.
The new behavior is:
```
some_command (+side effect) [enter/ctrl+c]
|<~~~~~~~~~~>|<~~~~~~~~~~~~~~~~~~~~~~~~~~~>|
| bold text | normal weight |
```
This commit is contained in:
+2
-2
@@ -153,7 +153,7 @@ class TestConfirm(object):
|
||||
|
||||
def test_with_side_effect_and_without_confirmation(self, capsys):
|
||||
assert main.confirm('command', Mock(), Mock(require_confirmation=False))
|
||||
assert capsys.readouterr() == ('', 'command*\n')
|
||||
assert capsys.readouterr() == ('', 'command (+side effect)\n')
|
||||
|
||||
# `stdin` fixture should be applied after `capsys`
|
||||
def test_when_confirmation_required_and_confirmed(self, capsys, stdin):
|
||||
@@ -165,7 +165,7 @@ class TestConfirm(object):
|
||||
def test_when_confirmation_required_and_confirmed_with_side_effect(self, capsys, stdin):
|
||||
assert main.confirm('command', Mock(), Mock(require_confirmation=True,
|
||||
no_colors=True))
|
||||
assert capsys.readouterr() == ('', 'command* [enter/ctrl+c]')
|
||||
assert capsys.readouterr() == ('', 'command (+side effect) [enter/ctrl+c]')
|
||||
|
||||
def test_when_confirmation_required_and_aborted(self, capsys, stdin):
|
||||
stdin.side_effect = KeyboardInterrupt
|
||||
|
||||
Reference in New Issue
Block a user