#702: fix minor issues with php_s rule

Unfortunately, I didn't catch these issues while reviewing #702.

After looking more closely at `php` options, `-S` requires additional
arguments (<address>:<port>) and `-s` may produce output if used that
way. So, matching ` -s ` seems to be better.

Also, `@for_app('php')` already asserts the presence of `php ` in the
command script. Matching `php -s` prevents the rule from fixing commands
like `php -t public -s 0.0.0.0:8080`.
This commit is contained in:
Pablo Santiago Blum de Aguiar
2017-10-10 14:48:47 -03:00
parent 64d6835e15
commit 75d2c43997
2 changed files with 13 additions and 9 deletions
+1 -4
View File
@@ -3,11 +3,8 @@ from thefuck.utils import replace_argument, for_app
@for_app('php')
def match(command):
return "php -s" in command.script
return " -s " in command.script
def get_new_command(command):
return replace_argument(command.script, "-s", "-S")
requires_output = False