fujin/ui-agregator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: separate albums/tracks into bordered panes, fix click handling

Browse Source 
- Replace single Detail pane with separate Albums and Tracks panes,
  each with its own border that highlights yellow when focused
- Store rendered Rect areas on LibraryState instead of hardcoding
  layout offsets, fixing album click selection
- Split render functions into public components for isolated testing
- Restructure snapshot tests by component (artists, albums, tracks,
  header, detail) — 13 tests expanded to 26
This commit is contained in:
Alexander
2026-05-09 19:42:48 +02:00
parent c1205e5fb0
commit 7a35958c42
23 changed files with 684 additions and 212 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/snapshots/ui_snapshots__albums_list_snapshots__mixed_statuses.snap
+14
View File
@@ -0,0 +1,14 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"● Complete Album [Album] 2020 ▰▰▰▰▰▰▰▰▰▰ 10/10 FLAC "
"○ Wanted Album [Album] 2021 ▱▱▱▱▱▱▱▱▱▱ 0/8 — "
"◌ Unmonitored Single [Single] 2022 ▱▱▱▱▱▱▱▱▱▱ 0/1 — "
" "
" "
" "
" "
" "
" "
" "
tests/snapshots/ui_snapshots__albums_list_snapshots__with_albums_focused.snap
+14
View File
@@ -0,0 +1,14 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"● OK Computer [Album] 1997 ▰▰▰▰▰▰▰▰▰▰ 12/12 FLAC "
"◐ Kid A [Album] 2000 ▰▰▰▰▰▱▱▱▱▱ 5/10 FLAC "
" "
" "
" "
" "
" "
" "
" "
" "
tests/snapshots/ui_snapshots__albums_list_snapshots__with_albums_unfocused.snap
+14
View File
@@ -0,0 +1,14 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"● OK Computer [Album] 1997 ▰▰▰▰▰▰▰▰▰▰ 12/12 FLAC "
"◐ Kid A [Album] 2000 ▰▰▰▰▰▱▱▱▱▱ 5/10 FLAC "
" "
" "
" "
" "
" "
" "
" "
" "
tests/snapshots/ui_snapshots__artist_header_snapshots__monitored_artist.snap
+10
View File
@@ -0,0 +1,10 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"Radiohead "
" "
"status ● Monitored path /music/Radiohead "
"quality FLAC size 2.5 GB "
"albums 2 tracks 17 / 22 "
" "
tests/snapshots/ui_snapshots__artist_header_snapshots__unmonitored_artist.snap
+10
View File
@@ -0,0 +1,10 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"Tool "
" "
"status ◌ Unmonitored path /music/Tool "
"quality FLAC size 3.8 GB "
"albums 0 tracks 0 / 0 "
" "
tests/snapshots/ui_snapshots__artists_pane_snapshots__empty.snap
+24
View File
@@ -0,0 +1,24 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 0 ]──────────────┐"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────┘"
tests/snapshots/ui_snapshots__artists_pane_snapshots__with_artists_focused.snap
+24
View File
@@ -0,0 +1,24 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 2 ]──────────────┐"
"│◐ Radiohead 17/22 │"
"│! Pink Floyd 0/10 │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────┘"
tests/snapshots/ui_snapshots__artists_pane_snapshots__with_artists_unfocused.snap
+24
View File
@@ -0,0 +1,24 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 2 ]──────────────┐"
"│◐ Radiohead 17/22 │"
"│! Pink Floyd 0/10 │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────┘"
tests/snapshots/ui_snapshots__detail_pane_snapshots__no_artist_selected.snap
+28
View File
@@ -0,0 +1,28 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"No artist selected "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
" "
tests/snapshots/ui_snapshots__detail_pane_snapshots__with_artist_albums_focused.snap
+28
View File
@@ -0,0 +1,28 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"Radiohead "
" "
"status ● Monitored path /music/Radiohead "
"quality FLAC size 2.5 GB "
"albums 2 tracks 17 / 22 "
" "
"┌─[ Albums · 2 releases ]──────────────────────────────────────────┐"
"│● OK Computer [Album] 1997 ▰▰▰▰▰▰▰▰▰▰ 12/12 FLAC │"
"│◐ Kid A [Album] 2000 ▰▰▰▰▰▱▱▱▱▱ 5/10 FLAC │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────────────────────────────────────────┘"
"┌─[ Tracks · OK Computer · 12/12 ]─────────────────────────────────┐"
"│(no album selected) │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────────────────────────────────────────┘"
tests/snapshots/ui_snapshots__detail_pane_snapshots__with_artist_tracks_focused.snap
+28
View File
@@ -0,0 +1,28 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"Radiohead "
" "
"status ● Monitored path /music/Radiohead "
"quality FLAC size 2.5 GB "
"albums 2 tracks 17 / 22 "
" "
"┌─[ Albums · 2 releases ]──────────────────────────────────────────┐"
"│● OK Computer [Album] 1997 ▰▰▰▰▰▰▰▰▰▰ 12/12 FLAC │"
"│◐ Kid A [Album] 2000 ▰▰▰▰▰▱▱▱▱▱ 5/10 FLAC │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────────────────────────────────────────┘"
"┌─[ Tracks · OK Computer · 12/12 ]─────────────────────────────────┐"
"│✓ 01 Airbag 4:44 FLAC │"
"│✓ 02 Paranoid Android 6:23 FLAC │"
"│✗ 03 Subterranean Homesick Alien 4:27 — │"
"│ │"
"│ │"
"│ │"
"└──────────────────────────────────────────────────────────────────┘"
tests/snapshots/ui_snapshots__library_page_snapshots__full_page_empty.snap
+34
View File
@@ -0,0 +1,34 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 0 ]──────────────┐No artist selected "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"│ │ "
"└──────────────────────────────┘ "
tests/snapshots/ui_snapshots__library_snapshots__albums_focused.snap → tests/snapshots/ui_snapshots__library_page_snapshots__full_page_with_data.snap
+10 -10
View File
@@ -2,14 +2,13 @@
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 2 ]──────────────┐┌─[ Detail · UK · Alternative ]────────────────────────────────────┐"
"│◐ Radiohead 17/22 ││Radiohead │"
"│! Pink Floyd 0/10 ││ │"
"│ ││status ● Monitored path /music/Radiohead │"
"│ ││quality FLAC size 2.5 GB │"
"│ ││albums 2 tracks 17 / 22 │"
"│ ││ │"
"│ ││─ albums ─ 2 releases │"
"┌─[ Artists · 2 ]──────────────┐Radiohead "
"│◐ Radiohead 17/22 │ "
"│! Pink Floyd 0/10 │status ● Monitored path /music/Radiohead "
"│ │quality FLAC size 2.5 GB "
"│ │albums 2 tracks 17 / 22 "
"│ │ "
"│ │┌─[ Albums · 2 releases ]──────────────────────────────────────────┐"
"│ ││● OK Computer [Album] 1997 ▰▰▰▰▰▰▰▰▰▰ 12/12 FLAC │"
"│ ││◐ Kid A [Album] 2000 ▰▰▰▰▰▱▱▱▱▱ 5/10 FLAC │"
"│ ││ │"
@@ -20,8 +19,8 @@ expression: terminal.backend()
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││─ tracks · OK Computer ─ 12/12 │"
"│ │└──────────────────────────────────────────────────────────────────┘"
"│ │┌─[ Tracks · OK Computer · 12/12 ]─────────────────────────────────┐"
"│ ││(no album selected) │"
"│ ││ │"
"│ ││ │"
@@ -31,4 +30,5 @@ expression: terminal.backend()
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"└──────────────────────────────┘└──────────────────────────────────────────────────────────────────┘"
tests/snapshots/ui_snapshots__library_snapshots__empty.snap
-34
View File
@@ -1,34 +0,0 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 0 ]──────────────┐┌─[ Detail · ]────────────────────────────────────────────────────┐"
"│ ││No artist selected │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"└──────────────────────────────┘└──────────────────────────────────────────────────────────────────┘"
tests/snapshots/ui_snapshots__library_snapshots__with_artists.snap
-34
View File
@@ -1,34 +0,0 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"┌─[ Artists · 2 ]──────────────┐┌─[ Detail · UK · Alternative ]────────────────────────────────────┐"
"│◐ Radiohead 17/22 ││Radiohead │"
"│! Pink Floyd 0/10 ││ │"
"│ ││status ● Monitored path /music/Radiohead │"
"│ ││quality FLAC size 2.5 GB │"
"│ ││albums 2 tracks 17 / 22 │"
"│ ││ │"
"│ ││─ albums ─ 2 releases │"
"│ ││● OK Computer [Album] 1997 ▰▰▰▰▰▰▰▰▰▰ 12/12 FLAC │"
"│ ││◐ Kid A [Album] 2000 ▰▰▰▰▰▱▱▱▱▱ 5/10 FLAC │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││─ tracks · OK Computer ─ 12/12 │"
"│ ││(no album selected) │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"│ ││ │"
"└──────────────────────────────┘└──────────────────────────────────────────────────────────────────┘"
tests/snapshots/ui_snapshots__tracks_list_snapshots__no_tracks.snap
+12
View File
@@ -0,0 +1,12 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"(no album selected) "
" "
" "
" "
" "
" "
" "
" "
tests/snapshots/ui_snapshots__tracks_list_snapshots__with_tracks_focused.snap
+12
View File
@@ -0,0 +1,12 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"✓ 01 Airbag 4:44 FLAC "
"✓ 02 Paranoid Android 6:23 FLAC "
"✗ 03 Subterranean Homesick Alien 4:27 — "
" "
" "
" "
" "
" "
tests/snapshots/ui_snapshots__tracks_list_snapshots__with_tracks_unfocused.snap
+12
View File
@@ -0,0 +1,12 @@
---
source: tests/ui_snapshots.rs
expression: terminal.backend()
---
"✓ 01 Airbag 4:44 FLAC "
"✓ 02 Paranoid Android 6:23 FLAC "
"✗ 03 Subterranean Homesick Alien 4:27 — "
" "
" "
" "
" "
" "