 noctuum
|
4bf094b6de
|
Check first against last in parse_object
A command ending in `=` reaches it with an empty range.
|
2026-09-30 10:58:35 +02:00 |
|
|
noctuum
|
a84743b008
|
Sort the transfer chunks by index
The default comparison ordered the pointers, not the chunk indexes.
|
2026-09-30 10:58:35 +02:00 |
|
|
noctuum
|
eebfb5f5e5
|
Check pthread_sigmask by its return value
`pthread_sigmask` returns the error number and does not set `errno`.
|
2026-09-30 10:58:35 +02:00 |
|
|
noctuum
|
991ebdabe0
|
Reject an empty argument list in execute_lua
`lua.execute` with no arguments dereferenced `args.begin()`.
|
2026-09-30 10:58:35 +02:00 |
|
|
noctuum
|
2aaf1cbfd1
|
Limit tab completion to text before the cursor
`substr` takes a count, so the text after the cursor joined the prefix.
|
2026-09-30 10:58:32 +02:00 |
|
|
noctuum
|
b5b37a2e07
|
Guard control in the main catch handlers
A start without HOME throws before control is constructed.
|
2026-09-30 10:58:20 +02:00 |
|
|
noctuum
|
4831a44879
|
Stop at max_active in scheduler.simple.removed
The limit was checked once, then every download was resumed.
|
2026-09-30 10:58:20 +02:00 |
|
|
xirvik
|
14c8d2b470
|
Sync the session directory after committing the renames
Syncing the files alone does not make the new names survive a crash.
|
2026-09-30 10:58:18 +02:00 |
|
|
Jari Sundell
|
15756ddadc
|
Reorder mutex and atomic variable declarations
|
2026-09-30 10:57:28 +02:00 |
|
|
xirvik
|
e0c0d96aba
|
Give SessionManager::m_active its own cache line
Prevents false sharing with the adjacent m_mutex under concurrent access.
|
2026-09-30 10:57:28 +02:00 |
|
|
xirvik
|
7fbe54d4dd
|
Make SessionManager::m_active atomic
It is written under m_mutex but read under m_pending_builds_mutex in one place.
|
2026-09-30 10:57:28 +02:00 |
|
|
xirvik
|
41209bc14d
|
Guard the download against handlers that erase it mid-close
Track a weak_ptr lifetime handle and make erase ignore re-entrant erase.
|
2026-09-30 10:57:28 +02:00 |
|
|
xirvik
|
47eb1432b6
|
Write session files with O_NOFOLLOW and mode 0600
Also make directory_entry::is_file() report the real type so symlinks are skipped.
|
2026-09-30 10:57:26 +02:00 |
|
|
xirvik
|
d16263701a
|
rpc: multicall requires methodName as the struct's first member
Faults clearly instead of the confusing positional parse error it replaces.
|
2026-09-30 10:57:09 +02:00 |
|
|
xirvik
|
d3f4d18164
|
Bound JSON-RPC input by size and nesting depth
Enforce the nesting bound in one parse, capping allocation by depth, not input size.
|
2026-09-30 10:57:09 +02:00 |
|
|
xirvik
|
6c6d2b9333
|
Range-check global throttle rates before narrowing them to kB.
Multiplying kB back to bytes in unsigned int wrapped 2^32 to 0, which means unlimited.
|
2026-09-30 10:56:59 +02:00 |
|
|
xirvik
|
f79cb257d7
|
Reject out-of-range RPC values instead of narrowing them silently.
Guards choke group max, set-port and info-hash length; parsing now uses std::from_chars.
|
2026-09-23 15:29:37 +00:00 |
|
|
rakshasa
|
05cdd03cd2
|
Tagged release 0.16.24.
v0.16.24
|
2026-09-22 15:24:24 +02:00 |
|
|
xirvik
|
d1a6942ea7
|
Keep the object_storage key terminator inside the key buffer
find_raw_string now honours the raw_string size instead of scanning for a nul.
|
2026-09-21 09:22:26 +02:00 |
|
|
xirvik
|
3652329e2d
|
Pass the typed download filter as an argument, not command text
A pattern containing '}' closed the match command early and ran the rest as commands.
|
2026-09-20 16:39:14 +02:00 |
|
|
xirvik
|
7916e6022f
|
Stop the value command on the untrusted-safe allowlist crashing the daemon
glibc leaves endptr unset for a small invalid base; ERANGE throws instead of clamping.
|
2026-09-20 15:58:47 +02:00 |
|
|
xirvik
|
c59da0848e
|
Dump the ipv4 filter by reference instead of copying the whole map
A static table owns the map; the loop only reads it on the main thread. No test needed.
|
2026-09-20 15:33:09 +02:00 |
|
|
xirvik
|
e2f66ff08c
|
Drop the address range parser and its includes, dead since 29edda2f
External linkage kept -Wunused-function quiet; a deletion of dead code needs no test.
|
2026-09-20 15:01:44 +02:00 |
|
|
xirvik
|
f0b6f2cb47
|
Fail p.multicall when a command changes the connection list
Disconnecting a peer frees it and reorders the list, so the iteration cannot continue.
|
2026-09-20 14:05:49 +02:00 |
|
|
xirvik
|
d334b8d339
|
Stop printing a strerror of si_errno in the SIGBUS dump
Linux leaves si_errno zero there, so the line always read Error: Success.
|
2026-09-20 10:05:55 +02:00 |
|
|
xirvik
|
19b71a98b7
|
Fix data race reading the log buffer from the display thread
Copy entries under the buffer lock before rendering; other threads mutate the deque.
|
2026-09-20 09:42:59 +02:00 |
|
|
xirvik
|
8ee3b984dd
|
Give network.xmlrpc.size_limit.set a floor
A limit below any valid request rejects the request that would raise it again.
|
2026-09-20 09:23:12 +02:00 |
|
|
xirvik
|
4e7129c71c
|
Keep starting when the DHT cache file is rejected
The router could throw while loading it, stopping rtorrent from starting at all.
|
2026-09-20 08:53:34 +02:00 |
|
|
xirvik
|
80ae6a4590
|
Answer an oversized RPC response with a fault
Cap XML-RPC and JSON-RPC output at the SCGI response limit before handing it over.
|
2026-09-19 18:04:09 +02:00 |
|
|
xirvik
|
2086e8e780
|
Check the argument count before indexing config comment log args
A '# do:log.add_output=debug' line read args[1] past the end of the vector.
|
2026-09-19 12:13:43 +02:00 |
|
|
xirvik
|
d9439d7a95
|
Dispatch view.event_added over the added half of the changed range
fb75510 pointed it at the removed half, so it fired on departing downloads instead.
|
2026-09-19 11:41:58 +02:00 |
|
|
noctuum
|
0d3404576a
|
Reject a throttle rate that overflows
rate * 1024 wraps to zero at 2^54, which means no limit.
|
2026-09-19 11:11:00 +02:00 |
|
|
noctuum
|
84a0d86f2c
|
Own the fault string in xmlrpc_error_c
xmlrpc_env_set_fault frees the buffer the pointer came from.
|
2026-09-19 10:34:46 +02:00 |
|
|
noctuum
|
1b15b7c518
|
Report a failed write in log.vmmap.dump
The dump is only flushed at fclose, whose result was discarded.
|
2026-09-19 10:11:23 +02:00 |
|
|
noctuum
|
b1be898ba1
|
Reject an over-long or empty object_storage key
key_type stores a key of key_size or longer as the empty key.
|
2026-09-18 16:54:48 +02:00 |
|
|
Jari Sundell
|
bd00b5f6fe
|
Use explicit device name binding rather than a custom syntax.
|
2026-09-18 23:19:43 +09:00 |
|
|
noctuum
|
b34eb1e895
|
Own the download factory until commit
A malformed data uri threw before commit, and nothing deleted it.
|
2026-09-18 11:24:30 +02:00 |
|
|
noctuum
|
b857acd081
|
Increment d.state_counter on pause
The start path increments it; the pause path assigned it to itself.
|
2026-09-18 11:05:31 +02:00 |
|
|
noctuum
|
988aca1281
|
Release the scgi task buffer on close
clear() keeps the capacity, and the task is pooled until exit.
|
2026-09-18 10:53:58 +02:00 |
|
|
noctuum
|
378c7ee854
|
Reject a throttle rate that does not parse
A discarded parse result left the rate at zero, which is unlimited.
|
2026-09-18 10:37:14 +02:00 |
|
|
noctuum
|
da9606bfae
|
Take ownership of the magnet metadata object
Nothing freed the bencode map the meta download built.
|
2026-09-18 10:17:28 +02:00 |
|
|
noctuum
|
8423803b6e
|
Check the flush on the dht cache and history
good() ran before close(), so a failed write replaced the file.
|
2026-09-17 16:13:55 +02:00 |
|
|
noctuum
|
c1ce2febf0
|
Reject an over-long line instead of truncating
getline sets failbit, which both loops read as end of input.
|
2026-09-17 11:33:44 +02:00 |
|
|
noctuum
|
5ebb7bd151
|
Call the target deleter in the tinyxml2 backend
A tracker target allocates, and the deleter went out of scope unused.
|
2026-09-17 10:33:45 +02:00 |
|
|
noctuum
|
50f0cad0c6
|
Release the xmlrpc array item on a throw
xmlrpc_to_target throws for an invalid target, skipping the DECREF.
|
2026-09-17 10:14:21 +02:00 |
|
|
noctuum
|
3717649bb3
|
Guard the value iterator in method.insert.list
The list branch dereferenced end() when no value was given.
|
2026-09-17 09:54:14 +02:00 |
|
|
noctuum
|
c32b56e9d8
|
Do not reschedule a deleted scheduler item
schedule.remove from the scheduled command deletes the item.
|
2026-09-16 11:37:19 +02:00 |
|
|
noctuum
|
de54a4c2ad
|
Clamp the negative width in wstring_width
A narrow terminal makes the file list width go below zero.
|
2026-09-16 11:18:54 +02:00 |
|
|
noctuum
|
26fdca8f4d
|
Use empty_visible in the view focus movers
empty() counts filtered entries, so size() - 1 underflows.
|
2026-09-16 10:57:25 +02:00 |
|
|
noctuum
|
00bcdaee23
|
Check the info-hash target in p.call_target
Without it an unknown info-hash segfaults the process.
|
2026-09-16 10:29:52 +02:00 |
|