fujin/Wizardry
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace calls to Item#isInCreativeTab(...) with a direct check, fixes metadata items not being displayed correctly in the creative inventory

Browse Source
This commit is contained in:
Electroblob77
2019-01-05 23:04:02 +00:00
parent 4ca89b2dca
commit 03e8682260
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/electroblob/wizardry/item/ItemArcaneTome.java
+1 -1
View File
@@ -26,7 +26,7 @@ public class ItemArcaneTome extends Item {
@Override @Override
public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list){ public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list){
if (isInCreativeTab(tab)) { if(tab == WizardryTabs.WIZARDRY){ // Don't use isInCreativeTab here.
for(int i = 1; i < Tier.values().length; i++){ for(int i = 1; i < Tier.values().length; i++){
list.add(new ItemStack(this, 1, i)); list.add(new ItemStack(this, 1, i));
} }
src/main/java/electroblob/wizardry/item/ItemScroll.java
+1 -1
View File
@@ -39,7 +39,7 @@ public class ItemScroll extends Item {
@Override @Override
public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list){ public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list){
if(isInCreativeTab(tab)){ if(tab == WizardryTabs.SPELLS){
// In this particular case, getTotalSpellCount() is a more efficient way of doing this since the spell instance // In this particular case, getTotalSpellCount() is a more efficient way of doing this since the spell instance
// is not required, only the id. // is not required, only the id.
for(int i = 0; i < Spell.getTotalSpellCount(); i++){ for(int i = 0; i < Spell.getTotalSpellCount(); i++){
src/main/java/electroblob/wizardry/item/ItemSpellBook.java
+1 -1
View File
@@ -36,7 +36,7 @@ public class ItemSpellBook extends Item {
@Override @Override
public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list){ public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list){
if(isInCreativeTab(tab)) { if(tab == WizardryTabs.SPELLS){
// In this particular case, getTotalSpellCount() is a more efficient way of doing this since the spell instance // In this particular case, getTotalSpellCount() is a more efficient way of doing this since the spell instance
// is not required, only the id. // is not required, only the id.
for(int i = 0; i < Spell.getTotalSpellCount(); i++){ for(int i = 0; i < Spell.getTotalSpellCount(); i++){